Skip to content

Conversation

@darukutsu
Copy link
Contributor

nitrogen & pywal don't set background on wayland. Therefore add swww.

@N-R-K N-R-K changed the title fix plugins/wallpaper support for wayland plugins/wallpaper: support wayland and fix indentation Nov 1, 2022
@jarun jarun merged commit a1477c2 into jarun:master Nov 2, 2022
@jarun
Copy link
Owner

jarun commented Nov 2, 2022

Thank you!

@jarun
Copy link
Owner

jarun commented Nov 2, 2022

@darukutsu if you can test Wayland, are there any other plugins which need changes to work on Wayland?

@jarun jarun mentioned this pull request Nov 2, 2022
1 task
@darukutsu
Copy link
Contributor Author

darukutsu commented Nov 3, 2022

@jarun everything looks ok.
The only plugin which behaves incorrectly is preview-tabbed.
Universal solution for wayland would be using wlrctl
It only works with urxvt and need to add line

previewer_loop() {
...
    wlrctl window focus title:nnn
    
    # Bruteforce focus stealing prevention method,
    # works well in floating window managers like ...
...
}

It's not suitable since user may have opened multiple instances with nnn, but other than that there is only compositor-specific solutions. I don't think it's needed if using something like preview-tui with kitty.

Also today discovered that alacritty supports XEmbed so maybe add to preview-tabbed

elif type alacritty >/dev/null 2>&1 ; then
    TERMINAL="alacritty --embed"

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants