icons: use a compact array #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a lot of the extension use the same icon. this can be exploited via having an array with all the unique icons and then storing a single byte index into the unique array. when using `O_EMOJI` this results in around ~1.7KiB drop in the total table size. `O_NERD` and `O_ICONS` get roughly ~0.5KiB savings.
|
Btw, on master I don't see any drop in binary size. But on my local branch (where I use additional compiler optimizations) I see some binary size drop as well. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of the extension use the same icon. this can be exploited via
having an array with all the unique icons and then storing a single byte
index into the unique array.
when using
O_EMOJIthis results in around ~1.7KiB drop in the totaltable size.
O_NERDandO_ICONSget roughly ~0.5KiB savings.