optim: only check types once#758
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Jul 19, 2020
Merged
Conversation
Change-Id: I998648be8181371ec14e23a3096dc3b4ac731957
Collaborator
|
The CI runs can vary highly and some came out slower than previous CI, but in other places there was a 10-20s improvement, which is big. I'll have to run it over a few times locally to get a more accurate estimate since CI runners aren't quite as stable. |
Collaborator
|
It's roughly another 10-15% perf boost, so together with #691 it's a 20-30% perf boost! YMMV of course though |
Collaborator
|
@allcontributors please add @Semperia for code |
Contributor
|
I've put up a pull request to add @Semperia! 🎉 |
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- each format has the same input, so type-checking only needs to occur once total - previously it was once per format Change-Id: I998648be8181371ec14e23a3096dc3b4ac731957 Co-authored-by: Lai Hongjie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #757
Change-Id: I998648be8181371ec14e23a3096dc3b4ac731957