Skip to content

Comments

(deps/clean): remove unused @types/ms devDep#674

Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5:remove-unused-types-ms
Apr 12, 2020
Merged

(deps/clean): remove unused @types/ms devDep#674
agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5:remove-unused-types-ms

Conversation

@agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Apr 12, 2020 •
edited
Loading

  • ms dep was removed in df39d02, but not its
    @types/ counterpart
  • @types/ms was added in 7033756 which also removed the only
    usage of ms
    • and the function that it was in that was removed was unused anyway

ms was removed in #57, but not @types/ms .
@types/ms was added in #54 which also removed the only usage of ms.

@agilgur5
(deps/clean): remove unused @types/ms devDep
552cf72 
- `ms` dep was removed in df39d02, but not its
  @types/ counterpart
- @types/ms was added in 7033756 which also removed the only
  usage of `ms`
  - and the function that it was in that was removed was unused anyway
@agilgur5 agilgur5 merged commit eaa5da7 into jaredpalmer:master Apr 12, 2020
agilgur5
agilgur5 commented Apr 12, 2020
View reviewed changes
Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. not much to see here

paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
@agilgur5 @paul-vd
(deps/clean): remove unused @types/ms devDep (jaredpalmer#674)
a32da4f 
- `ms` dep was removed in df39d02, but not its
  @types/ counterpart
- @types/ms was added in 7033756 which also removed the only
  usage of `ms`
  - and the function that it was in that was removed was unused anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@agilgur5