(refactor): replace ensureDistFolder with fs.outputFile#406
Merged
jaredpalmer merged 1 commit intojaredpalmer:masterfrom Jan 4, 2020
Merged
(refactor): replace ensureDistFolder with fs.outputFile#406jaredpalmer merged 1 commit intojaredpalmer:masterfrom
jaredpalmer merged 1 commit intojaredpalmer:masterfrom
Conversation
- fs.outputFile will create any directories that don't already exist - also remove extraneous ensureDistFolder w/ try-catch in build command
This was referenced Dec 31, 2019
Collaborator
|
thanks for the great PR! @all-contributors please add @agilgur5 for maintenance, docs, code and tests |
Contributor
|
I've put up a pull request to add @agilgur5! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.outputFile will create any directories that don't already exist
also remove extraneous ensureDistFolder w/ try-catch in build command
Follow-up to #402 (comment) . Was going to add this to that PR but it got merged in before I could