Skip to content

Mark formik as side-effect free #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 11, 2023
Merged

Mark formik as side-effect free #3501

merged 7 commits into from
Sep 11, 2023

Conversation

@markspolakovs
Copy link
Contributor

@markspolakovs markspolakovs commented Feb 28, 2022

This will allow Formik's code to be removed by tree-shaking bundlers like Webpack or esbuild.

@markspolakovs
Mark formik as side-effect free
406bf4d 
This will allow Formik's code to be removed by tree-shaking bundlers like Webpack or esbuild.
@vercel
Copy link

vercel bot commented Feb 28, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

formik-docs – ./

🔍 Inspect: https://vercel.com/jared/formik-docs/HdBhxhhdMWNSWB3GGgxWLLrHmZg9
✅ Preview: Failed

jaredpalmer
jaredpalmer previously approved these changes May 26, 2023
View reviewed changes
@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 887a70c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 2:19pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 26, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 887a70c:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

@quantizor quantizor self-requested a review as a code owner September 2, 2023 12:06
@quantizor quantizor added the automerge automerge label for kodiak label Sep 2, 2023
@kodiakhq kodiakhq bot merged commit fe4ed7e into jaredpalmer:main Sep 11, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
@ViktoriiaZinec ViktoriiaZinec mentioned this pull request May 17, 2024
Open
@alvinrumbaoa alvinrumbaoa mentioned this pull request May 24, 2024
Open
@ViktoriiaZinec ViktoriiaZinec mentioned this pull request May 24, 2024
Open
@ilshaad ilshaad mentioned this pull request May 24, 2024
Open
@s-laugh s-laugh mentioned this pull request May 25, 2024
Merged
@Manou-Codeur Manou-Codeur mentioned this pull request Sep 15, 2024
Open
@alvinrumbaoa alvinrumbaoa mentioned this pull request Sep 17, 2024
Open
@Manou-Codeur Manou-Codeur mentioned this pull request Sep 17, 2024
Open
@wainnyta wainnyta mentioned this pull request Sep 17, 2024
Open
@alvinrumbaoa alvinrumbaoa mentioned this pull request Sep 18, 2024
Open
@syofyanzuhad syofyanzuhad mentioned this pull request Sep 18, 2024
Open
@udilbar udilbar mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 20, 2024
Open
Open
@syofyanzuhad syofyanzuhad mentioned this pull request Sep 20, 2024
Open
@udilbar udilbar mentioned this pull request Sep 20, 2024
Open
@shonore shonore mentioned this pull request Sep 20, 2024
Open
@udilbar udilbar mentioned this pull request Sep 21, 2024
Open
@shonore shonore mentioned this pull request Sep 21, 2024
Open
@syofyanzuhad syofyanzuhad mentioned this pull request Sep 21, 2024
Open
@wainnyta wainnyta mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 22, 2024
Open
Open
@shonore shonore mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 22, 2024
Open
Open
@syofyanzuhad syofyanzuhad mentioned this pull request Sep 23, 2024
Open
@shonore shonore mentioned this pull request Sep 23, 2024
Open
@alvinrumbaoa alvinrumbaoa mentioned this pull request Sep 24, 2024
Open
@ilshaad ilshaad mentioned this pull request Sep 25, 2024
Open
@udilbar udilbar mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 28, 2024
Open
Open
This was referenced Nov 4, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quantizor quantizor quantizor approved these changes

@jaredpalmer jaredpalmer jaredpalmer left review comments

@johnrom johnrom Awaiting requested review from johnrom

Assignees

No one assigned

Labels

automerge automerge label for kodiak

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markspolakovs @quantizor @jaredpalmer