Support scopes defined both in strategy constructor and authenticate()#99
Closed
anabellaspinelli wants to merge 1 commit into
Closed
Support scopes defined both in strategy constructor and authenticate()#99anabellaspinelli wants to merge 1 commit into
anabellaspinelli wants to merge 1 commit into
Conversation
Author
|
@jaredhanson @tomhughes @Tug @natalan Hello! This change (or something like it) would be really helpful for me and (Typeform), the company I work for. I noticed there are a lot of pending PRs. Is this the correct way to request a review? Thank you! |
|
@anabellaspinelli if you make a PR against https://github.com/passport-next/passport-oauth2 is will get looked into. |
Author
|
Thank you @rwky I will! Just out of curiosity, what's the purpose of the fork? |
|
One of the companies I work for uses several passport modules and maintained our own forks, since the upstream modules aren't maintained I decided to fork them publicly in an organization so even if I get hit by a bus they won't go unmaintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding this feature for cases in which strategy users want to have default scope set up in their Strategy constructor (maybe something like
profile) and then customize other scopes based on user selection.Right now, the scope that comes in the
authenticate()optionsobject overrides whatever was set up in the constructor.Tested it in the following scenarios: