Skip to content

readme strategy options#93

Open
dan-nl wants to merge 2 commits into
jaredhanson:masterfrom
dan-nl:feature/readme-strategy-options
Open

readme strategy options#93
dan-nl wants to merge 2 commits into
jaredhanson:masterfrom
dan-nl:feature/readme-strategy-options

Conversation

@dan-nl

@dan-nl dan-nl commented Oct 27, 2017

Copy link
Copy Markdown

this resolves #28, resolves #46, resolves #57, resolves #91

@coveralls

coveralls commented Oct 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling db7b564 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling db7b564 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@dan-nl dan-nl force-pushed the feature/readme-strategy-options branch 2 times, most recently from db59053 to e5813f2 Compare October 27, 2017 21:25
@coveralls

coveralls commented Oct 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling db59053 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls

coveralls commented Oct 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e5813f2 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@dan-nl dan-nl force-pushed the feature/readme-strategy-options branch 2 times, most recently from 21e9d81 to 57daaf5 Compare October 27, 2017 21:42
@dan-nl dan-nl force-pushed the feature/readme-strategy-options branch from 57daaf5 to e9e133a Compare October 27, 2017 21:44
@coveralls

coveralls commented Oct 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e9e133a on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls

coveralls commented Oct 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 21e9d81 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 21e9d81 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 21e9d81 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls

coveralls commented Oct 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e9e133a on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

Comment thread README.md Outdated

#### state
OPTIONAL<br>
`{ sessionKey: boolean }`<br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/paste bug :) This should say "state"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@coveralls

coveralls commented Oct 28, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling a8cda94 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling a8cda94 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@rwky

rwky commented Jul 7, 2018

Copy link
Copy Markdown

@MrOrz

MrOrz commented Jun 25, 2020

Copy link
Copy Markdown

Info in this PR is very valuable, thank you @dan-nl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants