Backport use of \z in glob.#146
Merged
Merged
Conversation
Owner
jaraco
commented
Jun 8, 2025
- gh-133306: Use \z instead of \Z in regular expressions in the stdlib (GH-133337)
- Add a compatibility shim for Python 3.13 and earlier.
jaraco
commented
Jun 8, 2025
Comment on lines
+26
to
+31
| def replace(pattern): | ||
| r""" | ||
| >>> replace(r'foo\z') | ||
| 'foo\\Z' | ||
| """ | ||
| return pattern[:-2] + pattern[-2:].replace(r'\z', r'\Z') |
Owner
Author
There was a problem hiding this comment.
This could be made more generic, such as supporting \z not as the last pair of characters and supporting \\z (not replacing it), but I'm going to ignore those use-cases until they're potentially needed (such as making this compatibility shim more widely available).
97cbade to
1b52c36
Compare
1b52c36 to
717d770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.