Super Upgrade PR#837
Open
lucas42 wants to merge 14 commits into
Open
Conversation
Use a version of ngrok which runs on recent versions of Windows and MacOS. Switch to using the npm `overrides` property, to avoid needing to mantain a separate fork of `zuul-ngrok`
Browser usage
Upgrade modules used in github actions to latest supported version
Upgrade action node versions
Manually install `esm` as part of the legacy test job, and ignore the lockfile
Upgrade npm dev dependencies
This was referenced May 22, 2024
Author
|
@jedidja no, I've not heard anything since I raised these PRs a year ago. I don't think this project is being actively maintained. |
|
Before people start pouring a lot of effort into a fork, please consider that there are more Mustache implementations for JavaScript:
(There is also Milk, but that one went out of maintenance almost immediately in 2011.) |
Author
|
@jedidja I did publish my collective changes to npm last year, so I could include it in one of my projects: https://www.npmjs.com/package/mustache-dynamic-names But I don't really want to become the sole maintainer of a fork relied on by others. |
Author
|
@jgonggrijp good luck with your library too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a bunch of individual Pull Requests to upgrade parts of this repository.
However, merging them all will cause a bunch of conflicts. This pull request combines them all into a single PR with the conflicts already sorted.
This covers:
For the purposes of review, you may wish look at each of those individually to understand the changes.
(Fixes #832)