Standardize Order of `is` and `are` Arguments

[E-A-Griffin]

Standardize repo to always take expected as the first arg to the form and actual as the second (or nth)

ex:

(testing "inc"
  (is (= 1 (inc 0)))
  (are [expected in] (= expected in)
    0 -1))

instead of

(testing "inc"
  (is (= (inc 0) 1))
  (are [in expected] (= in expected)
    -1 0))

[jeaye]

Sounds good!

[dgr]

I suggest creating a “how to write tests” document that lists the expectations for standards like this. You should have PR reviewers looking for these issues before applying PRs so you aren’t continually trying to change things after the merge. I was planning on doing that many months ago but it got away from me and never happened. The closest I got was creating the test template.

[jeaye]

I agree this would be a great win. Dave, you have the most stat points put into testing, is that a doc you'd be interested in writing? I'd actually link my mentees to it, with the goal of them learning from your methodology.

[dgr]

Okay, I can take a run at it.