Skip to content

Conversation

@tikikun
Copy link
Contributor

@tikikun tikikun commented Dec 4, 2023

No description provided.

@tikikun tikikun self-assigned this Dec 4, 2023
@tikikun tikikun linked an issue Dec 4, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Preview URL: https://cc626b8c.jan-qn8.pages.dev

@tikikun tikikun marked this pull request as draft December 4, 2023 10:58
@hiro-v
Copy link
Contributor

hiro-v commented Dec 4, 2023

You should add here instead: https://github.com/janhq/jan/blob/main/docs/openapi/specs/models.yaml
This applies to all changes @tikikun

@hiro-v hiro-v requested a review from a team December 4, 2023 19:11
@dan-menlo
Copy link
Contributor

dan-menlo commented Dec 5, 2023

@vuonghoainam @tikikun Quick question - are we able to embed or reference a JSON schema as part of a Swaggerfile?

cc @hieu-jan

@tikikun
Copy link
Contributor Author

tikikun commented Dec 5, 2023

You should add here instead: https://github.com/janhq/jan/blob/main/docs/openapi/specs/models.yaml This applies to all changes @tikikun

Doesn't look right since this is value range for the model and engine section

@tikikun tikikun marked this pull request as ready for review December 5, 2023 12:04
@louis-jan louis-jan changed the title add json schema for engine and model parameters docs: add json schema for engine and model parameters Dec 6, 2023
@tikikun tikikun merged commit ca0ad7d into main Dec 8, 2023
@tikikun tikikun deleted the 813-feat-json-schema-for-frontend-parameters branch December 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

feat: json schema for frontend parameters

6 participants