Skip to content

Conversation

@tikikun
Copy link
Contributor

@tikikun tikikun commented Nov 28, 2023

Descriptive example with correct reference to nitro docs for:

  • Model parameters
  • Model settings

@tikikun tikikun requested a review from a team November 28, 2023 04:03
@tikikun tikikun self-assigned this Nov 28, 2023
@tikikun tikikun linked an issue Nov 28, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Preview URL: https://4c6aea5b.jan-qn8.pages.dev


The model settings in the example can be found at: (Nitro's model settings)[https://nitro.jan.ai/features/load-unload#table-of-parameters]

The model paramemters in the example can be found at: (Nitro's model parameters)[https://nitro.jan.ai/api-reference#tag/Chat-Completion]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Mispelled parameters
  2. URL formatting is wrong, shouldn't it be , not ()[]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @0xSage i have fixed the link issue, but what you mean by parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm saw the issue

@tikikun tikikun requested a review from louis-jan November 29, 2023 09:38
@tikikun tikikun merged commit 4c2c320 into main Nov 29, 2023
@tikikun tikikun deleted the 741-chore-adding-correct-example-for-model-parameters-with-examples branch November 29, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

chore: Adding correct example for model parameters with examples

4 participants