Skip to content

Conversation

@Lokimorty
Copy link
Contributor

@Lokimorty Lokimorty commented Nov 27, 2025

Describe Your Changes

The "Show variants" toggle in Hub uses a Switch component, but toggle is not the right design pattern here. Toggles are for settings that apply immediately—in this context we're just expanding a layout to show more content.

Replaced the Switch with a clickable chevron:

  • Text "Show variants" with chevron icon to the right
  • Entire line is clickable, not just the icon
  • Chevron points down when collapsed, up when expanded
  • Matches styling of other icons in the row (size 18, text-main-view-fg/50 color)

To test it:

  1. Open Hub
  2. Find a model with multiple variants (look for variant count > 1)
  3. Click "Show variants" text or the chevron
  4. Verify the variants list expands and chevron flips to point up
  5. Click again to collapse

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from Vanalite November 30, 2025 06:45
@Vanalite
Copy link
Contributor

Vanalite commented Dec 1, 2025

I agree that the chevron up/down looks more reasonable than a toggle, but it this icon is too off, blended to the text and background that users might not notice @Lokimorty

Screenshot 2025-12-01 at 6 41 00 PM

@Lokimorty
Copy link
Contributor Author

From my point of view:

Variants is a secondary feature — casual users don't need it, and the segment of users that does will look for it specifically which will make it hard to miss. We want it accessible but not competing for attention with the other elements in the card

With the chevron icon I prioritized consistency (of color, size) with other icons in this card

I can see an option where we align "Show variants" to the right end of the card to highlight it using the hierarchy. This way we can make it more visible without changing the color or size to keep it consistent. Let me know if you see it differently @Vanalite

CleanShot 2025-12-01 at 15 30 52@2x

@Vanalite
Copy link
Contributor

Vanalite commented Dec 8, 2025

@Lokimorty You make a good point of "We want it accessible but not competing for attention with the other elements"
Pls update your branch with your suggestion and we will look into it again

@Lokimorty Lokimorty force-pushed the hub-chevron-variants branch 2 times, most recently from c59eaa4 to 266ec68 Compare December 8, 2025 15:32
@Lokimorty
Copy link
Contributor Author

@Vanalite updated

The "Show variants" toggle uses a Switch component, but toggle is not
the right design pattern here. Toggles are for settings that apply
immediately—in this context we're just expanding a layout to show more
content.

Replaced the Switch with a clickable chevron:
- Text "Show variants" with chevron icon to the right
- Entire line is clickable, not just the icon
- Chevron points down when collapsed, up when expanded
- Matches styling of other icons in the row (size 18, text-main-view-fg/50)
@louis-jan louis-jan force-pushed the hub-chevron-variants branch from 266ec68 to fa024f6 Compare December 9, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants