Skip to content

fix: app shows wrong performance tag, all say not enough ram on windows #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: app shows wrong performance tag, all say not enough ram on windows #699

merged 1 commit into from
Nov 23, 2023

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 23, 2023 •
edited
Loading

Problem

Solution

  • It seems like PerformanceTag hook would just persist once, it is not updated as soon as app can retrieve the total RAM value.

Address the 1st issue of #624

linhtran174
linhtran174 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@linhtran174 linhtran174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green tag on a Windows PC with 128GB RAM so it should be good

@louis-jan louis-jan merged commit f7f1e3d into main Nov 23, 2023
@louis-jan louis-jan deleted the fix/ridiculous-not-enough-ram-warning branch November 23, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urmauur urmauur urmauur approved these changes

@namchuai namchuai Awaiting requested review from namchuai

+1 more reviewer

@linhtran174 linhtran174 linhtran174 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Menlo
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@louis-jan @linhtran174 @urmauur