Skip to content

Conversation

@qnixsynapse
Copy link
Contributor

Describe Your Changes

This commit introduces a change to prevent Markdown rendering issues where a dollar sign followed by a number (like $1) is incorrectly interpreted as LaTeX by the rendering engine.

The normalizeLatex function in RenderMarkdown.tsx now explicitly escapes these sequences (e.g., $1 becomes \$1), ensuring they are displayed literally instead of being processed as mathematical expressions. This improves the fidelity of text that might contain currency or similar numerical notations.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

This commit introduces a change to prevent **Markdown** rendering issues where a dollar sign followed by a number (like **`$1`**) is incorrectly interpreted as **LaTeX** by the rendering engine.

---

The `normalizeLatex` function in `RenderMarkdown.tsx` now explicitly escapes these sequences (e.g., **`$1`** becomes **`\$1`**), ensuring they are displayed literally instead of being processed as mathematical expressions. This improves the fidelity of text that might contain currency or similar numerical notations.
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 29.73%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/src/containers/RenderMarkdown.tsx1-16, 28, 34, 36-38, 40, 42-44, 47-49, 51, 54-57, 60-63, 67, 69-71, 74-78, 80-81, 84-94, 96-100, 102, 105-113, 115-121, 123-125, 127-130, 138-145, 147-151, 153-156, 158-171, 173-181, 183-192, 194-196, 198-199, 201, 203-211, 214, 217-219, 222-225, 228, 231-237, 240-242, 245-256, 259-270, 273-279, 281-284, 286-288, 290-294

Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qnixsynapse qnixsynapse merged commit 147cab9 into dev Oct 16, 2025
21 checks passed
@qnixsynapse qnixsynapse deleted the fix/renderMarkDownInlineDollarSign branch October 16, 2025 06:45
@github-project-automation github-project-automation bot moved this to QA in Jan Oct 16, 2025
@github-actions github-actions bot added this to the v0.7.2 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

4 participants