Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Oct 8, 2025

Describe Your Changes

Issue
Screenshot 2025-10-08 at 12 32 50

This pull request simplifies the ProjectPage component by removing the logic that checks for valid model providers and the related conditional rendering of the SetupScreen. It also makes minor formatting improvements to translation calls and component props for better readability.

Removed provider setup logic:

  • Removed the import and usage of useModelProvider, as well as the conditional check for valid providers and the rendering of the SetupScreen. This means the page no longer blocks access if no valid model providers are configured. [1] [2] [3]

Formatting and readability improvements:

  • Reformatted translation (t) calls and the ThreadList component props to improve code readability and maintain consistency. [1] [2]

Fixes Issues

Screenshot 2025-10-08 at 12 38 05

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copilot AI review requested due to automatic review settings October 8, 2025 05:48
@urmauur urmauur self-assigned this Oct 8, 2025
@urmauur urmauur added this to the v0.7.2 milestone Oct 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the provider gating logic from ProjectPage so projects behave like threads even when no model providers are configured, plus small readability tweaks.

  • Remove provider check/useModelProvider and SetupScreen rendering
  • Reformat i18n calls and ThreadList props for readability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Barecheck - Code coverage report

Total: 30.43%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/src/routes/project/$projectId.tsx1-2, 4-6, 8-11, 13-18, 20-22, 24-28, 30-31, 34, 37-41, 43-54, 56, 58-63, 65-66, 68-74, 76-88, 90, 93-99, 101-116, 118-121, 123-128, 130-136, 138

@urmauur urmauur moved this to Needs Review in Jan Oct 8, 2025
@urmauur urmauur merged commit 814034d into dev Oct 8, 2025
21 checks passed
@urmauur urmauur deleted the fix/remove-setup-screen branch October 8, 2025 12:16
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

bug: Inconsistent thread access behavior between Project and Projects views when no models available

3 participants