Skip to content

Conversation

@dinhlongviolin1
Copy link
Contributor

Describe Your Changes

  • projects enhancement
  • fix performance issue, thread should not overfetch items during load

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

* decouple successfully

* only show movable projects for project items

* handle delete covnersations when projects is removed

* fix leftpanel assignemtn

* fix lint
* fix: thread item overfetching

* chore: cleanup left over import
Copilot AI review requested due to automatic review settings October 1, 2025 15:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements projects/folders functionality enhancement and addresses a performance issue by preventing overfetching of thread messages during initial load.

  • Added comprehensive projects service architecture with localStorage-based storage
  • Removed automatic message fetching for all threads during app initialization to improve performance
  • Enhanced project deletion flow with thread count awareness and starred thread warnings

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
web-app/src/services/projects/types.ts Defines interfaces for projects service operations
web-app/src/services/projects/default.ts Implements localStorage-based projects service
web-app/src/services/projects/web.ts Web-specific projects service extending default
web-app/src/services/index.ts Integrates projects service into service hub
web-app/src/hooks/useThreadManagement.ts Refactored to use projects service instead of zustand persistence
web-app/src/containers/dialogs/DeleteProjectDialog.tsx Enhanced with thread statistics and improved messaging
web-app/src/providers/DataProvider.tsx Removed automatic message fetching to fix performance issue
web-app/src/providers/AuthProvider.tsx Removed automatic message fetching to fix performance issue
web-app/src/services/threads/default.ts Added metadata spreading for thread operations
web-app/src/locales/en/common.json Added improved delete dialog messages
web-app/src/routes/project/index.tsx Updated to use async project operations
web-app/src/routes/project/$projectId.tsx Added currentProjectId prop to ThreadList
web-app/src/containers/ThreadList.tsx Enhanced project filtering logic
web-app/src/containers/LeftPanel.tsx Updated to use async project operations
web-app/src/containers/ChatInput.tsx Simplified project assignment logic
web-app/src/hooks/useChat.ts Added project metadata handling for new threads

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Barecheck - Code coverage report

Total: 31.48%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
web-app/src/containers/ChatInput.tsx112-114, 132, 156-157, 159-161, 173-175, 177-178, 192-193, 220-221, 243-245, 252-253, 256-259, 262-272, 275, 277-279, 285, 287, 289-290, 292-296, 299-300, 303, 305-308, 310-314, 316-328, 330-340, 342-351, 353-356, 359-360, 362-365, 368-369, 372-376, 379-380, 382-385, 388-390, 393-395, 398-401, 403-404, 406-410, 412-414, 418-420, 423-426, 428-429, 431-432, 434-439, 442-448, 450-454, 457, 459-463, 466-473, 475-478, 480-482, 484-495, 497-503, 505-511, 514-517, 519, 555-563, 565-570, 572-574, 576-578, 580-581, 639, 679-693, 709-711, 716-720, 735-739, 754-768, 771-785, 793-802, 810, 828, 840-846, 848-854, 859-868
web-app/src/containers/LeftPanel.tsx105-108, 120, 123-127, 130-141, 187-189, 203-205, 208-210, 213-216, 218-225, 230, 244-246, 248-256, 266, 269-270, 274, 293, 306-312, 314-315, 324-327, 329-345, 347-348, 350, 355-356, 360-364, 366, 368, 370, 378-379, 406-420, 422-428, 430-434, 436, 438-449, 451-467, 469-476, 478-485, 487, 489-492, 499-527, 529-544, 546-547, 551-563, 565-578, 582-592, 632, 655-660
web-app/src/containers/ThreadList.tsx48-51, 55-63, 65-66, 68-82, 84-90, 92-98, 100-105, 107, 110-111, 113-115, 117, 119-123, 125-132, 134-139, 141-143, 145-147, 149-154, 156-175, 177-181, 183-187, 189-193, 195-214, 216-218, 220-224, 226-228, 230-235, 237-245, 247-248, 250-256, 258-263, 265-270, 272-282, 284-287, 289-301, 303, 317, 338
web-app/src/containers/dialogs/DeleteProjectDialog.tsx38-43, 45-48, 52, 54-66, 69-72, 82-84, 90-97, 99-101, 108-110
web-app/src/hooks/useChat.ts91-95, 98-108, 110-123, 129-138, 148-170, 173, 175, 177, 180, 183-188, 190-191, 196-198, 201-205, 208, 211-213, 215-225, 269-270, 274, 278-282, 288-289, 291-294, 296-309, 311-322, 324-331, 334-338, 340-343, 345-355, 357-361, 363-366, 368-395, 397-415, 417-419, 422, 424-426, 428-429, 432-438, 440-441, 443-449, 451-456, 458-461, 463-471, 474, 476, 478-493, 495-500, 502-511, 513-523, 526-533, 535-548, 550, 553, 555-557, 563-564
web-app/src/hooks/useThreadManagement.ts22-23, 26-31, 34-38, 42-45, 47-54, 56-60, 64-67, 70-73, 76-78, 81-82, 84-86, 89-90, 93-95, 107
web-app/src/providers/AuthProvider.tsx6-15, 21-24, 27-28, 31-33, 36-41, 44, 46-48, 51-52, 55-56, 59-60, 63-64, 66-70, 72-75, 77, 79-84, 86-87, 90-93, 95, 97-98, 101, 103-104, 108, 110, 112-114, 116-119, 122, 124-126, 128, 130-133, 135-136
web-app/src/providers/DataProvider.tsx55-57, 60, 70-71, 97-98, 103, 111-114, 116-120, 123-128, 130, 133-137, 140-158, 164-168, 170, 173, 175-181
web-app/src/routes/project/$projectId.tsx1-2, 4-7, 9-13, 15-20, 22-24, 26-31, 33-34, 37, 40-44, 47-52, 54-56, 58-69, 71, 73-78, 80-81, 83-89, 91-101, 103, 106-108, 110-121, 123-126, 128-133, 135-141, 143
web-app/src/routes/project/index.tsx1-2, 4-6, 8-10, 18-20, 22, 24-26, 28-30, 32-44, 46-49, 51-54, 56-60, 62-69, 71-73, 76-82, 84-94, 96-107, 109-125, 127-133, 135-138, 140-152, 154-176, 178, 180-184, 186-189, 191, 193-199, 201-209, 211-217, 220-226, 228, 230-231, 233-248, 250
web-app/src/services/index.ts196-199, 204-207, 302-304
web-app/src/services/projects/default.ts13-22, 25-34, 37-38, 41-45, 47-49, 51-52, 55-62, 65-68, 71-73, 76-77

@Minh141120
Copy link
Member

LGTM!
image

image image image

@Minh141120 Minh141120 merged commit 8e10f27 into release/v0.7.0 Oct 1, 2025
17 checks passed
@Minh141120 Minh141120 deleted the cherry-pick/projects branch October 1, 2025 16:42
@github-project-automation github-project-automation bot moved this to QA in Jan Oct 1, 2025
@github-actions github-actions bot added this to the v0.7.0 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants