fix: mcp bin path #6667
Merged
fix: mcp bin path #6667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the bin path construction for MCP (Model Context Protocol) executables on Windows by using proper PathBuf operations instead of string concatenation. The change ensures cross-platform compatibility when checking for executable existence and also updates the download script to use the latest release URLs instead of hardcoded versions.
- Replaces string formatting with
PathBuf::join()for proper path construction - Updates download URLs to use latest releases instead of hardcoded versions
- Adds comprehensive tests for path construction on different platforms
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src-tauri/src/core/mcp/helpers.rs | Replaces string formatting with PathBuf::join() for bun and uv path construction |
| src-tauri/src/core/mcp/tests.rs | Adds tests for path construction including Windows-specific test cases |
| scripts/download-bin.mjs | Updates download URLs to use latest releases instead of hardcoded versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
louis-jan
force-pushed
the
fix/mcp-bin-path
branch
from
54bf92e to
c998288
Compare
louis-jan
requested review from
Minh141120,
Vanalite,
dinhlongviolin1 and
urmauur
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
louis-jan
force-pushed
the
fix/mcp-bin-path
branch
from
190d896 to
7c21648
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
LGTM 
|
Minh141120
approved these changes
Sep 30, 2025
louis-jan
added a commit
that referenced
this pull request
Oct 6, 2025
* feat: Init mobile app from current Tauri v2 framework Feat: - Using Tauri v2 by default - Add new configuration to initiate mobile app - Add dependencies needed for mobile build Test: - Confirm to be built successfully - Confirm to keep settings for desktop and build successfully - Reuse most of components from desktop version * fix: Fix tests * feat: Add android target * fix: Reconfigure and add toolchain to wake up Android app * fix: Fix parsing datatype inconsistent across platforms * feat: Adjust UI for mobile res Feature: - Adjust homecreen and chatscreen for mobile device - Fix tests for both FE and BE Self-test: - Confirm runnable on both Android and iOS - Confirm runnable on desktop app - All test suites passed - Working with ChatGPT API * fix: Restore dedupe command * chore: Adjust paddings to save some space for the top nav bar * Update web-app/src/routes/index.tsx Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * chore: keep gen icon on Android * chore: add command to ease the mobile dev * chore: Separate configuration for android build in release mode * chore: Shrink the Android app size to minimal, release type * feat: Disable zoom and setup mobile viewport * chore: Configure iOS to use the same build mechanic to remove unnecessary plugin * fix: Remove redundant yarn command for ios dev build * enhancement: fit mobile layout * chore: update chatscreen padding * chore: update checking platform using config isntead navigation agent * chore: update height of thread detail * remove gen android * Update web-app/src/index.css Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * fix: Add frontendDist to ios configuration * feat: Experiment removing hardware permission * fix: Android releasable build * feat: Add dev-android to makefile * feat: Add dev-ios to makefile for ios development * refactor(utils): add helper to remove extensions from file paths * chore: fix Encoded logging * refactor: safely strip prefix and extensions from filename * chore: add logging for TauriDialog Service * Update handbook content with Nextra callout and content improvements - Convert blockquote to Nextra callout in open-superintelligence.mdx - Add Edison link and improve content flow - Refine language for better clarity * docs: enhance overview page with improved structure and internal linking - Restructured main content with cleaner formatting - Added comprehensive internal linking for better navigation - Improved visual hierarchy and readability - Enhanced acknowledgements section with better organization - Updated product suite section with consistent formatting * Update handbook navigation structure and meta.json files - Updated handbook/_meta.json to properly organize navigation - Fixed duplicate entries by removing files that belong in subfolders - Updated why folder title to 'Why does Jan exist?' - Cleaned up why/_meta.json with proper titles for Open Superintelligence and Open-Source sections * docs: fix broken internal links and remove privacy page - Fix broken links in troubleshooting.mdx pointing to install pages - Remove privacy.mdx page and update _meta.json navigation - Update various documentation links for consistency - Ensure all internal links use proper absolute paths * Optimize installation pages SEO meta titles and descriptions ✨ SEO Improvements: - Mac: 'Run AI models locally on your Mac - Jan' - Linux: 'Run AI models locally on Linux - Jan' - Windows: 'Run AI models locally on Windows - Jan' 🎯 Meta descriptions now include: - Target keywords (local AI, LLM, offline, ChatGPT-like) - Platform-specific details (Apple Silicon, Ubuntu/Debian, Windows 10/11) - Key benefits (GPU acceleration, privacy, no internet required) 📍 Sidebar navigation titles unchanged - only SEO meta data optimized * Clean up installation page titles and descriptions - Revert titles to clean sidebar navigation (Mac, Linux, Windows) - Improve meta descriptions to be concise but SEO-friendly - Keep key terms: local AI, offline, GPU acceleration, platform details * Update README.md * Update README.md * trigger PR banner * docs: update missing redirect links * enhancement: social media navbar and update menu footer * Update docs/src/components/Navbar.tsx Co-authored-by: Copilot <[email protected]> * Update docs/src/components/Navbar.tsx Co-authored-by: Copilot <[email protected]> * fix: Apply model name change correctly # Conflicts: # web-app/src/lib/utils.ts * feat: Disable text selection on Toaster Disable the option to select text on the Toaster to consist the swiping action on the toast in order to dismiss it * fix: scroll issue padding not re render correctly (#6639) * trigger PR banner * Improve FAQ section and content updates for offline ChatGPT alternative post * Add SEO-optimized Twitter meta titles for installation pages - Add Twitter meta tags to Windows, Linux, and Mac installation pages - Optimize meta titles: 'Jan on [Platform]' for better SEO - Maintain consistent meta descriptions across all platforms - Keep original page titles unchanged for user experience * Update content files - Update tabby server example - Update troubleshooting documentation - Update NVIDIA TensorRT-LLM benchmarking post * Add ChatGPT alternative blog post and update installation docs * Update ChatGPT alternative blog post * Rename blog post from chatgpt-alternative-jan.mdx to chatgpt-alternatives.mdx * feat: add real-time ChatGPT status checker blog post - Add new blog post: 'is-chatgpt-down-use-jan' - Create OpenAIStatusChecker React component with real-time data - Use CORS proxy to fetch live OpenAI status from status.openai.com - Include SEO-optimized status indicators and error messages - Add ChatGPT downtime promotion for Jan alternative - Component features: auto-refresh, fallback handling, dark mode support * chore: fix typo * chore: fix failed build * refactor: deprecate Vulkan external binaries (#6638) * refactor: deprecate vulkan binary refactor: clean up vulkan lib chore: cleanup chore: clean up chore: clean up fix: build * fix: skip binaries download env * Update src-tauri/utils/src/system.rs Co-authored-by: Copilot <[email protected]> * Update src-tauri/utils/src/system.rs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * feat: Add tests for the model displayName modification * fix: Fix linter error * fix: Fix nvidia and vulkan after upgrade to be compatible with mobile compiling too * Fix OG image paths and move images to general folder - Move OG images from _assets/ to public/assets/images/general/ - Update all blog post references to use correct paths - Remove duplicate images from _assets/ folder - Fix image paths in content to use /assets/images/general/ format - Update Twitter image references to match OG image paths Files updated: - chatgpt-alternatives.mdx - deepresearch.mdx - deepseek-r1-locally.mdx - how-we-benchmark-kernels.mdx - is-chatgpt-down-use-jan.mdx - offline-chatgpt-alternative.mdx - qwen3-settings.mdx - run-ai-models-locally.mdx - run-gpt-oss-locally.mdx * fix: remove Jan prefix from blog post titles for better SEO - Blog posts now use only frontmatter title without 'Jan -' prefix - Other pages maintain existing branding (Jan Desktop, Jan Server, Jan) - Improves SEO for blog content while preserving site branding * update blog post content * Feat: web temporary chat (#6650) * temporray chat stage1 * temporary page in root * temporary chat * handle redirection properly ` * temporary chat header * Update extensions-web/src/conversational-web/extension.ts Co-authored-by: Copilot <[email protected]> * update routetree * better error handling * fix strecthed assitant on desktop * update yarn link to workspace for better link consistency --------- Co-authored-by: Copilot <[email protected]> * Add Guides category to blog navigation - Add 'guides' category to staticCategories array in Blog component - Update plopfile.js to include guides in category choices - Add guides category entry to _meta.json - Position guides category after research in navigation * docs: update redirect links * Update AI for Law blog post with images and content improvements - Add hero image for AI for Law blog post - Add images to assistant creation and contract review sections - Improve content structure and readability - Add proper image assets for legal AI use cases - Update ogImage and twitter image references * fix: revert the modification of vulkan * Add AI for Teachers blog post with images and video - Create comprehensive AI for Teachers blog post - Add hero image and assistant creation interface images - Include video demonstration of Jan for teachers - Add proper ogImage and twitter image references - Cover lesson planning, grading, parent communication, and classroom resources - Focus on privacy and offline AI for educational use * fix: Fix linter and tests * fix: Restore default permission on desktop build Restore desktop capabilities Restore linter correctness Restore different capabilities on each platform * fix: Fix cargo test * feat: web add search button for extension (#6671) * add search button for web extension * change button color and behavior * Update extensions-web/src/mcp-web/components/WebSearchButton.tsx Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * add eof new line missing (#6673) * fix lint issue * fix: mcp bin path (#6667) * fix: mcp bin path * chore: clean up unused structs * fix: bin name * fix: tests * remove test conflict * add missing closing test * fix tauri test * feat: disable all web mcp by default (new users) (#6677) * fix: chat completion usage - token speed (#6675) * resolve TypeScript and Rust warnings (#6612) * chore: fix warnings * fix: add missing scrollContainerRef dependencies to React hooks * fix: typo * fix: remove unsupported fetch option and enable AsyncIterable types - Removed `connectTimeout` from fetch init (not supported in RequestInit) - Updated tsconfig to target ES2018 * chore: refactor rename * fix(hooks): update dependency arrays for useThreadScrolling effects * Add type.d.ts to extend requestinit with connectionTimeout * remove commentd unused import * fix: Fix editing model without saving should restore original name * fix: thread item overfetching (#6699) * fix: thread item overfetching * chore: cleanup left over import * feat: improve projects (#6698) * decouple successfully * only show movable projects for project items * handle delete covnersations when projects is removed * fix leftpanel assignemtn * fix lint * fix gg tag (#6702) * refactor: resolve rust analyzer warnings and improve code quality (#6696) - Update string formatting to use modern interpolation syntax - Simplify expressions and remove unnecessary intermediate variables - Improve logging statements for better readability - Clean up code across core modules (app, downloads, mcp, server, etc.) * docs: add Jan v0.7.0 changelog * docs: update Jan v0.7.0 changelog content * docs: rename changelog file to remove trailing dash * feat: use sql for mobile storage * feat: organize code for proper import Move platform checker for db access to helper Add test for to threads controller * feat: better structure for MobileCoreService MobileCoreService should inherit TauriCoreService to match Tauri architecture patterns * fix: Extract model capabilities correctly for various providers on various platforms * fix: yarn lint * ci: remove upload msi * fix: extensions missing on Unix dev (#6724) * fix: extensions missing on Unix dev * re add bun uv for mcp * fix: Local API Server - disable settings on run (#6707) * fix: Fix tests in threads with proper mock folder properly * changelog: release 0.7.1 * chore: wrong version in detail changelog * fix: update detail changelog 0.7.1 * fix(ui): restore missing border on model selector (#6692) * fix: Fix openssl issue on mobile after merging * fix: Remove yarn.lock changes * chore(ui): refine className for dropdown menu with animation states * chore: Reposition 'Remove project' option for better usability * feat: add project search and scrollable thread lists - Add search bar to filter projects by name in real-time - Implement scrollable thread container with max 4 visible threads - Add empty state for no search results - Add clear button (X) to reset search query * (chore): rename translation keys to collapseProject/expandProject * Fix Translation changes across locales * (chore): remove duplicate keys from de-DE/common.json * Add SearchProjects to missing locales * fix: theme native system and check os support blur * fix: new window theme * fix: open new window theme * fix: test use case appearance * chore: fix window type theme service * chore: update permission windows * chore: fix desktop capabilities * chore: check support blur using hardware api * chore: check support blur on FE * chore: fix new chat with update last selected model dropdown * fix: tittle recent when no result found --------- Co-authored-by: Vanalite <[email protected]> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Faisal Amir <[email protected]> Co-authored-by: Roushan Singh <[email protected]> Co-authored-by: eckartal <[email protected]> Co-authored-by: Emre Can Kartal <[email protected]> Co-authored-by: Roushan Kumar Singh <[email protected]> Co-authored-by: Nguyen Ngoc Minh <[email protected]> Co-authored-by: Minh141120 <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Dinh Long Nguyen <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Follow up on PR #6638 to correct the bin path when checking for path existence on Windows.
This PR also makes these changes:
Fixes Issues
Self Checklist