-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: pathname file install BE #6464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 18114c0 in 1 minute and 53 seconds. Click for details.
- Reviewed
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_w7xqC2f63X3Qg8He
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed 5736d7b in 1 minute and 44 seconds. Click for details.
- Reviewed
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/dialogs/BackendUpdater.tsx:50
- Draft comment:
The conditional check now only considers 'remindMeLater' (removing autoUpdateEnabled). Confirm that this change in behavior is intended. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_Z4MZKKVFTEHTGr35
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed e02be47 in 53 seconds. Click for details.
- Reviewed
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/dialogs/BackendUpdater.tsx:37
- Draft comment:
Removed debug logging is acceptable in production. If future diagnostics are needed, consider a logging utility that toggles debug logs based on environment. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_58QYekKl6cFCLXPL
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.


Describe Your Changes
This pull request makes a small change to how the file path is handled when installing a backend in the
ProviderDetailcomponent. Instead of processing the file path to replace spaces with dashes and convert it to lowercase, the originalselectedFilevalue is now passed directly to theinstallBackendfunction.(web-app/src/routes/settings/providers/$providerName.tsxL360-R362)
Fixes Issues
Self Checklist
Important
Pass
selectedFiledirectly toinstallBackendinProviderDetailand add logging inBackendUpdater.tsx.ProviderDetail, passselectedFiledirectly toinstallBackendinstead of processing it.BackendUpdater.tsxto indicate when the notification is not shown due toremindMeLater.This description was created by
for e02be47. You can customize this summary. It will automatically update as commits are pushed.