Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Sep 15, 2025

Describe Your Changes

This pull request makes a small change to how the file path is handled when installing a backend in the ProviderDetail component. Instead of processing the file path to replace spaces with dashes and convert it to lowercase, the original selectedFile value is now passed directly to the installBackend function.

(web-app/src/routes/settings/providers/$providerName.tsxL360-R362)

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Pass selectedFile directly to installBackend in ProviderDetail and add logging in BackendUpdater.tsx.

  • Behavior:
    • In ProviderDetail, pass selectedFile directly to installBackend instead of processing it.
  • Logging:
    • Add logging in BackendUpdater.tsx to indicate when the notification is not shown due to remindMeLater.

This description was created by Ellipsis for e02be47. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.10 milestone Sep 15, 2025
@urmauur urmauur self-assigned this Sep 15, 2025
@urmauur urmauur added this to Jan Sep 15, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 18114c0 in 1 minute and 53 seconds. Click for details.
  • Reviewed 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_w7xqC2f63X3Qg8He

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed 5736d7b in 1 minute and 44 seconds. Click for details.
  • Reviewed 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/dialogs/BackendUpdater.tsx:50
  • Draft comment:
    The conditional check now only considers 'remindMeLater' (removing autoUpdateEnabled). Confirm that this change in behavior is intended.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_Z4MZKKVFTEHTGr35

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed e02be47 in 53 seconds. Click for details.
  • Reviewed 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/dialogs/BackendUpdater.tsx:37
  • Draft comment:
    Removed debug logging is acceptable in production. If future diagnostics are needed, consider a logging utility that toggles debug logs based on environment.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_58QYekKl6cFCLXPL

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@Minh141120
Copy link
Member

LGTM!
image
image

@urmauur urmauur moved this to Needs Review in Jan Sep 15, 2025
@urmauur urmauur merged commit da2f790 into release/v0.6.10 Sep 16, 2025
16 checks passed
@urmauur urmauur deleted the fix/pathname-install-be branch September 16, 2025 03:14
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants