Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Aug 19, 2025

Describe Your Changes

This PR bumps inference client version with the fix of using passed fetch option for inferencing so that custom providers will not have CORS issue.

CleanShot 2025-08-19 at 13 44 19@2x CleanShot 2025-08-19 at 13 45 13@2x

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Update token.js to version 0.7.23 in package.json to fix CORS issue with custom fetch option.

  • Dependencies:
    • Update token.js version from 0.7.22 to 0.7.23 in package.json to fix CORS issue by using custom fetch option.

This description was created by Ellipsis for 65f23fb. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 65f23fb in 52 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/package.json:75
  • Draft comment:
    Version bump to [email protected] detected. Confirm that this new version includes the fix to use the custom fetch (thereby addressing the CORS issues with remote Ollama LLMs) and that corresponding tests or changelog updates exist.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm the inclusion of a specific fix in a version bump, which is related to dependencies. This violates the rule against commenting on dependency changes or asking for confirmations about them.

Workflow ID: wflow_2ji40owIGnoiJlbf

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 37.33%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-jan louis-jan merged commit b32c8b3 into dev Aug 19, 2025
17 checks passed
@louis-jan louis-jan deleted the fix/use-tauri-fetch-for-custom-providers branch August 19, 2025 08:17
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 19, 2025
@github-actions github-actions bot added this to the v0.6.9 milestone Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: Unable to connect Jan to remote Ollama LLMs

3 participants