Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Aug 15, 2025

This pull request makes a minor update to the flatpak/ai.jan.Jan.yml file, specifically changing the hash used to verify the CUDA toolkit installer from MD5 to the more secure SHA-256 algorithm. This improves the security and integrity of the installer verification process.

  • Security improvement:
    • Updated the hash verification for the CUDA toolkit installer from md5 to sha256 in flatpak/ai.jan.Jan.yml.

Important

Update hash verification for CUDA toolkit installer from MD5 to SHA-256 in flatpak/ai.jan.Jan.yml.

  • Security Improvement:
    • Updated hash verification for CUDA toolkit installer from md5 to sha256 in flatpak/ai.jan.Jan.yml.

This description was created by Ellipsis for c38f8a9. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c38f8a9 in 47 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. flatpak/ai.jan.Jan.yml:95
  • Draft comment:
    Ensure the new SHA‑256 checksum matches the installer binary. This update looks good for security.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_8BJCVlfneF35G1VV

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 merged commit 8d1ad03 into dev Aug 15, 2025
1 check passed
@Minh141120 Minh141120 deleted the chore/update-flatpak-manifest branch August 15, 2025 09:39
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 15, 2025
@github-actions github-actions bot added this to the v0.6.9 milestone Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants