fix: migrations model setting

web-app/src/hooks/useModelProvider.ts

@@ -30,123 +30,123 @@
       selectedModel: null,
       deletedModels: [],
       getModelBy: (modelId: string) => {
         const provider = get().providers.find(
           (provider) => provider.provider === get().selectedProvider
         )
         if (!provider) return undefined
         return provider.models.find((model) => model.id === modelId)
       },
       setProviders: (providers) =>
         set((state) => {
           const existingProviders = state.providers
             // Filter out legacy llama.cpp provider for migration
             // Can remove after a couple of releases
             .filter((e) => e.provider !== 'llama.cpp')
             .map((provider) => {
               return {
                 ...provider,
                 models: provider.models.filter(
                   (e) =>
                     ('id' in e || 'model' in e) &&
                     typeof (e.id ?? e.model) === 'string'
                 ),
               }
             })
 
           let legacyModels: Model[] | undefined = []
           /// Cortex Migration
           if (
             localStorage.getItem('cortex_model_settings_migrated') !== 'true'
           ) {
             legacyModels = state.providers.find(
               (e) => e.provider === 'llama.cpp'
             )?.models
             localStorage.setItem('cortex_model_settings_migrated', 'true')
           }
           // Ensure deletedModels is always an array
           const currentDeletedModels = Array.isArray(state.deletedModels)
             ? state.deletedModels
             : []
 
           const updatedProviders = providers.map((provider) => {
             const existingProvider = existingProviders.find(
               (x) => x.provider === provider.provider
             )
             const models = (existingProvider?.models || []).filter(
               (e) =>
                 ('id' in e || 'model' in e) &&
                 typeof (e.id ?? e.model) === 'string'
             )
             const mergedModels = [
               ...(provider?.models ?? []).filter(
                 (e) =>
                   ('id' in e || 'model' in e) &&
                   typeof (e.id ?? e.model) === 'string' &&
                   !models.some((m) => m.id === e.id) &&
                   !currentDeletedModels.includes(e.id)
               ),
               ...models,
             ]
             const updatedModels = provider.models?.map((model) => {
               const settings =
                 (legacyModels && legacyModels?.length > 0
                   ? legacyModels
                   : models
                 ).find(
                   (m) => m.id.split(':').slice(0, 2).join(sep()) === model.id
                 )?.settings || model.settings
               const existingModel = models.find((m) => m.id === model.id)
               return {
                 ...model,
                 settings: settings,
                 capabilities: existingModel?.capabilities || model.capabilities,
               }
             })
 
             return {
               ...provider,
               models: provider.persist ? updatedModels : mergedModels,
               settings: provider.settings.map((setting) => {
                 const existingSetting = provider.persist
                   ? undefined
                   : existingProvider?.settings?.find(
                       (x) => x.key === setting.key
                     )
                 return {
                   ...setting,
                   controller_props: {
                     ...setting.controller_props,
                     ...(existingSetting?.controller_props || {}),
                   },
                 }
               }),
               api_key: existingProvider?.api_key || provider.api_key,
               base_url: existingProvider?.base_url || provider.base_url,
               active: existingProvider ? existingProvider?.active : true,
             }
           })
           return {
             providers: [
               ...updatedProviders,
               ...existingProviders.filter(
                 (e) => !updatedProviders.some((p) => p.provider === e.provider)
               ),
             ],
           }
         }),
       updateProvider: (providerName, data) => {
         set((state) => ({
           providers: state.providers.map((provider) => {
             if (provider.provider === providerName) {
               return {
                 ...provider,
                 ...data,
               }
             }
             return provider
           }),
         }))
       },
       getProviderByName: (providerName: string) => {
         const provider = get().providers.find(
           (provider) => provider.provider === providerName
@@ -156,9 +156,9 @@
       },
       selectModelProvider: (providerName: string, modelName: string) => {
         // Find the model object
         const provider = get().providers.find(
           (provider) => provider.provider === providerName
         )
 
         let modelObject: Model | undefined = undefined
 
@@ -227,42 +227,31 @@
           >
         }
 
-        // Migration for cont_batching description update (version 0 -> 1)
         if (version === 0 && state?.providers) {
-          state.providers = state.providers.map((provider) => {
+          state.providers.forEach((provider) => {
+            // Update cont_batching description for llamacpp provider
             if (provider.provider === 'llamacpp' && provider.settings) {
-              provider.settings = provider.settings.map((setting) => {
-                if (setting.key === 'cont_batching') {
-                  return {
-                    ...setting,
-                    description:
-                      'Enable continuous batching (a.k.a dynamic batching) for concurrent requests.',
-                  }
-                }
-                return setting
-              })
+              const contBatchingSetting = provider.settings.find(
+                (s) => s.key === 'cont_batching'
+              )
+              if (contBatchingSetting) {
+                contBatchingSetting.description =
+                  'Enable continuous batching (a.k.a dynamic batching) for concurrent requests.'
+              }
             }
-            return provider
-          })
-        }
 
-        // Migration for chatTemplate key to chat_template (version 1 -> 2)
-        if (version === 1 && state?.providers) {
-          state.providers.forEach((provider) => {
+            // Migrate model settings
             if (provider.models) {
               provider.models.forEach((model) => {
-                // Initialize settings if it doesn't exist
-                if (!model.settings) {
-                  model.settings = {}
-                }
+                if (!model.settings) model.settings = {}
 
                 // Migrate chatTemplate key to chat_template
                 if (model.settings.chatTemplate) {
                   model.settings.chat_template = model.settings.chatTemplate
                   delete model.settings.chatTemplate
                 }
 
-                // Add missing chat_template setting if it doesn't exist
+                // Add missing settings with defaults
                 if (!model.settings.chat_template) {
                   model.settings.chat_template = {
                     ...modelSettings.chatTemplate,
@@ -271,22 +260,7 @@
                     },
                   }
                 }
-              })
-            }
-          })
-        }
-
-        // Migration for override_tensor_buffer_type key (version 2 -> 3)
-        if (version === 2 && state?.providers) {
-          state.providers.forEach((provider) => {
-            if (provider.models) {
-              provider.models.forEach((model) => {
-                // Initialize settings if it doesn't exist
-                if (!model.settings) {
-                  model.settings = {}
-                }
 
-                // Add missing override_tensor_buffer_type setting if it doesn't exist
                 if (!model.settings.override_tensor_buffer_t) {
                   model.settings.override_tensor_buffer_t = {
                     ...modelSettings.override_tensor_buffer_t,
@@ -303,7 +277,7 @@
 
         return state
       },
-      version: 3,
+      version: 1,
     }
   )
 )