-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: Improve error message for invalid version/backend format #6149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit changes the error message displayed when the `version_backend` configuration is invalid. The new message is more user-friendly and suggests a simple solution, such as restarting the application, which is more helpful to the user than the previous technical error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 2503662 in 2 minutes and 5 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/llamacpp-extension/src/index.ts:1168
- Draft comment:
Typographical error: 'Intial' should be spelled 'Initial'. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_6bGep0Z5uDOYreKE
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed 23ae0bb in 2 minutes and 4 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_EWLAjMGXU8bJ3AgM
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 28.66%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
* fix: Improve error message for invalid version/backend format This commit changes the error message displayed when the `version_backend` configuration is invalid. The new message is more user-friendly and suggests a simple solution, such as restarting the application, which is more helpful to the user than the previous technical error message. * fix typo
Describe Your Changes
This PR changes the error message displayed when the
version_backendconfiguration is invalid. The new message is more user-friendly and suggests a simple solution, such as restarting the application, which is more helpful to the user than the previous technical error message.Fixes Issues
Self Checklist
Important
Updates error message in
llamacpp_extensionclass inindex.tsfor invalidversion_backendformat to be more user-friendly.llamacpp_extensionclass inindex.tsfor invalidversion_backendformat to "Initial setup for the backend failed due to a network issue. Please restart the app!"This description was created by
for 23ae0bb. You can customize this summary. It will automatically update as commits are pushed.