Skip to content

bug: cancelling a model download should be delete the model file on user data #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

bug: cancelling a model download should be delete the model file on user data #613

merged 1 commit into from
Nov 14, 2023

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Nov 13, 2023

Fix #605

Test scenario:

  1. Download a model -> go to user data models you should see the file name current download
  2. Cancel download --> go to user data models you should not see the file name anymore
Screenshot 2023-11-13 at 23 06 11

@urmauur urmauur merged commit 52b96e6 into main Nov 14, 2023
@urmauur urmauur deleted the bug/cancel-download-model branch November 14, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louis-jan louis-jan louis-jan approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Menlo
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Cancelling a model download does not delete the model file

3 participants

@urmauur @louis-jan