Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 31, 2025

Describe Your Changes

Fixed the model selection issue where it auto switch back to unselected value when there is a colon in model name

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Fixes model selection issue by replacing colons with slashes in model IDs for 'llama.cpp' in useThreads.ts.

  • Behavior:
    • Fixes issue with model selection reverting when model ID contains a colon in useThreads.ts.
    • Updates model ID processing to replace colons with slashes for 'llama.cpp' and 'llamacpp' providers.
  • Tests:
    • Updates useThreads.test.ts to expect model IDs with slashes instead of colons for 'llama.cpp' models.

This description was created by Ellipsis for f86a4f9. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 8eb8e71 in 1 minute and 34 seconds. Click for details.
  • Reviewed 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/useThreads.ts:47
  • Draft comment:
    Ensure removal of the ':free' check is intentional: previously, ids ending with ':free' were not split. Now splitting is based solely on provider. Confirm this change meets business requirements.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The comment is asking for verification of intention, which is explicitly against our rules. The code has a clear comment explaining the purpose of the change (Cortex migration). The change appears intentional and documented. Asking for business requirement confirmation is not appropriate for code review. Maybe the change in behavior could introduce bugs if some IDs with ':free' suffix are handled differently in other parts of the codebase? Even if there are potential issues elsewhere, that would be a cross-file concern which we're explicitly told to ignore. The change is clearly documented as part of a migration. Delete the comment as it violates our rules by asking for intention verification and business requirement confirmation. The change is clearly documented as part of a migration.

Workflow ID: wflow_cUmT25jID8dyTkwP

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed f86a4f9 in 44 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/__tests__/useThreads.test.ts:90
  • Draft comment:
    Updated expected model id from 'thread1:free' to 'thread1/free' to match the new normalization. Ensure all parts of the codebase that reference model IDs follow this new format.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that all parts of the codebase follow the new format for model IDs. This falls under the rule of not asking the author to ensure behavior is intended or to double-check things. Therefore, this comment should be removed.

Workflow ID: wflow_fqc8SVWEH3y0G7Dn

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan louis-jan merged commit 4bcfa84 into release/v0.6.6 Jul 31, 2025
10 checks passed
@louis-jan louis-jan deleted the hotfix/regression-issue-with-colon-in-model-name branch July 31, 2025 10:55
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 31, 2025
@github-actions github-actions bot added this to the v0.6.7 milestone Jul 31, 2025
@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 38.63%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
web-app/src/hooks/useThreads.ts49, 51, 87, 89-93, 144-146, 162-167, 171, 186-194, 196, 199, 202, 204-210, 212-230, 232-246, 270-272, 275-278, 281-282, 285, 287-294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants