fix(#591): prevent duplicate message id issue #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
force-pushed
the
fix/591
branch
5 times, most recently
from
3eb25f7 to
de96ddb
Compare
Signed-off-by: James <[email protected]>
louis-jan
reviewed
Nov 13, 2023
louis-jan
reviewed
Nov 13, 2023
louis-jan
reviewed
Nov 13, 2023
louis-jan
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #591 . This issue happen when assistant about to reply to user's inference request. Currently, we immediately create an empty message for assistant to response. We can add a small delay before create that empty message response.