fix: update default GPU toggle, and simplify state

[urmauur]

Describe Your Changes

This pull request refactors the useLlamacppDevices hook to simplify device activation management by incorporating the activation status directly into the devices array. It removes the separate activatedDevices state and updates related components and tests accordingly.

Refactor of device activation management:

• web-app/src/hooks/useLlamacppDevices.ts: Removed the activatedDevices state and added an activated property to each device in the devices array. Updated the fetchDevices and toggleDevice methods to handle activation status directly within the devices array. [1] [2] [3]

• web-app/src/services/hardware.ts: Updated the DeviceList interface to include an activated property and ensured that devices fetched from the llamacpp extension include their activation status. [1] [2]

Updates to tests:

• web-app/src/hooks/__tests__/useLlamacppDevices.test.ts: Updated tests to reflect the new activation status handling. Removed references to activatedDevices and validated the activated property within the devices array. [1] [2] [3]

Component updates:

• web-app/src/routes/settings/hardware.tsx: Removed logic for initializing activatedDevices and updated UI bindings to use the activated property of devices. [1] [2] [3]

• web-app/src/routes/system-monitor.tsx: Simplified the component by removing initialization logic for activatedDevices and updated UI elements to reflect the new activated property. [1] [2] [3] [4]

Other updates:

• web-app/src/routes/settings/providers/$providerName.tsx: Adjusted llamacpp device activation reset logic to use the updated fetchDevices method instead of setActivatedDevices.

Fixes Issues

• Closes bug: GPU settings display incorrectly on first launch - toggled ON in settings but shows OFF in GUI #5898
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Refactor useLlamacppDevices to manage device activation within devices array, updating components and tests accordingly.

• Behavior:
  • Refactor useLlamacppDevices in useLlamacppDevices.ts to include activated status in devices array, removing activatedDevices state.
  • Update fetchDevices and toggleDevice to manage activation within devices.
  • Modify DeviceList in hardware.ts to include activated property.
• Tests:
  • Update useLlamacppDevices.test.ts to validate activated property in devices and remove activatedDevices references.
• Components:
  • Update hardware.tsx and system-monitor.tsx to use activated property for UI logic.
  • Adjust llamacpp device activation reset logic in $providerName.tsx to use fetchDevices.

^{This description was created by for ed8442e. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to ed8442e in 1 minute and 3 seconds. Click for details.

• Reviewed 417 lines of code in 6 files
• Skipped 0 files when reviewing.
• Skipped posting 5 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/hooks/__tests__/useLlamacppDevices.test.ts:80

• Draft comment:
  The 'should set devices directly' test passes a device object without an explicit 'activated' property. Since the new type requires 'activated: boolean', consider updating the test fixture to include it (e.g. activated: false) for consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. web-app/src/hooks/useLlamacppDevices.ts:95

• Draft comment:
  In toggleDevice, updateSettings is awaited without error handling. Consider wrapping the updateSettings call in a try/catch block to handle potential provider update failures gracefully.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. web-app/src/routes/settings/hardware.tsx:87

• Draft comment:
  Removal of manual activatedDevices initialization simplifies the component. Ensure that fetchDevices reliably initializes the activation state for all devices as intended.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

4. web-app/src/routes/settings/providers/$providerName.tsx:369

• Draft comment:
  Replacing setActivatedDevices with a call to fetchDevices for resetting activation state is appropriate. If rapid backend changes occur, consider debouncing the fetchDevices call to avoid excessive updates.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

5. web-app/src/services/hardware.ts:10

• Draft comment:
  The DeviceList interface now includes an 'activated' property. Ensure that the llamacpp extension’s getDevices() either supplies this property or that the hook correctly assigns it during mapping.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_Xj4vomFYT1QbHBes

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 38.68%

Your code coverage diff: 0.08% ▴

Uncovered files and lines

File	Lines
web-app/src/hooks/useLlamacppDevices.ts	38, 50-53, 76-78, 80, 82-93, 95-99
web-app/src/routes/system-monitor.tsx	2-12, 14-16, 18-20, 22-25, 27, 29, 31-32, 35-44, 46-47, 50-54, 58-59, 61-68, 70, 72-109, 112-155, 158-176, 178-196, 198-200, 202-203, 205-206, 208
web-app/src/routes/settings/hardware.tsx	74, 81, 93-99, 106, 108-110, 112, 114-116, 118-125, 128-130, 133-140, 299, 301-306, 308, 328-330, 350
web-app/src/routes/settings/providers/$providerName.tsx	2-8, 15, 22-42, 45-47, 49-53, 55-86, 89-97, 99, 101, 104-106, 108-109, 112-113, 115, 117-122, 125-126, 128-131, 137-143, 145-150, 152-153, 155-160, 162-168, 170-172, 175-181, 184-187, 189, 191-195, 197-221, 223, 225-235, 237-239, 241-251, 253-290, 292-298, 301-302, 304-311, 313-323, 327-329, 332, 335-337, 339-350, 353-357, 359-362, 365-366, 369, 371-375, 377-384, 386-389, 391, 394-403, 405-409, 411-421, 423-425, 427-428, 430-431, 433, 435-436, 439-456, 458-463, 465-468, 470-476, 478-479, 481-496, 498-501, 503-511, 513-523, 525-534, 536-537, 540-550, 552-555, 557-567, 569-581, 583-584, 586-591, 593-599, 601, 603, 605, 607, 609, 611, 613-620, 622-624, 626-632, 634
web-app/src/services/hardware.ts	34-37, 39-41, 43-44

[louis-jan]

LGTM and works great!