Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Jul 26, 2025

Describe Your Changes

Screenshot 2025-07-26 at 11 37 49 Screenshot 2025-07-26 at 11 39 38

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Adds global event handling for settings changes, updates memory usage calculations, and refactors llamacpp device handling for macOS.

  • Global Event Handling:
    • Adds GlobalEventHandler in GlobalEventHandler.tsx to handle settingsChanged events globally, specifically for version_backend changes.
    • Integrates GlobalEventHandler into __root.tsx.
  • Memory Usage Calculation:
    • Updates RAM usage calculation in hardware.tsx and system-monitor.tsx to use systemUsage.used_memory / hardwareData.total_memory.
  • Llamacpp Devices Handling:
    • Uses default values for llamacpp devices on macOS in hardware.tsx.
    • Conditionally renders GPU usage information based on OS in system-monitor.tsx.

This description was created by Ellipsis for 3ad6b75. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.6 milestone Jul 26, 2025
@urmauur urmauur requested review from Minh141120 and louis-jan July 26, 2025 04:40
@urmauur urmauur self-assigned this Jul 26, 2025
@urmauur urmauur added this to Jan Jul 26, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 11041b0 in 1 minute and 52 seconds. Click for details.
  • Reviewed 181 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/providers/GlobalEventHandler.tsx:15
  • Draft comment:
    Consider defining a dedicated type or interface for the event parameter instead of using an inline type. This will improve type safety and clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. web-app/src/routes/__root.tsx:166
  • Draft comment:
    GlobalEventHandler is correctly mounted within the ExtensionProvider. Verify that its placement meets the intended event propagation strategy across the entire app.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. web-app/src/routes/settings/hardware.tsx:45
  • Draft comment:
    Ensure that the global variable IS_MACOS is defined and used intentionally. Also, the update for memory usage now calculates used memory (used_memory/total_memory). Consider adding a guard to handle a potential division by zero if total_memory might be zero.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
4. web-app/src/routes/settings/providers/$providerName.tsx:132
  • Draft comment:
    The local subscription to the settingsChanged event has been removed in favor of the global handler. Confirm that all provider-specific update logic is still executed as intended.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. web-app/src/routes/system-monitor.tsx:97
  • Draft comment:
    RAM usage is now computed using (used_memory / total_memory * 100). Consider adding a guard against division by zero, and note that similar logic for initializing llamacpp device activations appears in multiple components—refactoring into a shared hook might improve maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
6. web-app/src/routes/settings/providers/$providerName.tsx:134
  • Draft comment:
    Typographical issue: The comment says "This ensures all screens receive the event intermediately." It seems likely that "intermediately" should be replaced with "immediately," which better conveys the intended behavior.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct (intermediately vs immediately is likely a typo), comments about typos in comments are generally not useful enough to warrant a PR comment. Comments should focus on actual code issues that need to be fixed. Documentation/comment typos are too minor to warrant slowing down the PR review process. The typo could potentially cause confusion for future developers reading the code, since "intermediately" has a different meaning than "immediately". While true, the meaning is still fairly clear from context and this is just a code comment, not customer-facing text. The cost of the back-and-forth PR review process outweighs the minor benefit of fixing this typo. Delete this comment. While technically correct, comments about typos in code comments are too minor to warrant a PR comment.

Workflow ID: wflow_AQMjvE22Z7yv9iFx

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2025

Barecheck - Code coverage report

Total: 38.6%

Your code coverage diff: -0.01% ▾

Uncovered files and lines
FileLines
web-app/src/providers/GlobalEventHandler.tsx1-4, 10-11, 14-15, 18-19, 22-23, 25-34, 41, 44, 47-50, 53-54
web-app/src/routes/__root.tsx1, 4-25, 30-32, 34-37, 39-47, 50, 53-56, 59-67, 69-73, 75-76, 79-83, 86-90, 92-95, 98, 101-108, 110, 112, 115-119, 121-125, 127-129, 131, 133-137, 139-146, 148, 150-151, 153-156, 158-168, 170-175, 177
web-app/src/routes/system-monitor.tsx2-13, 15-17, 19-21, 23-29, 31, 33, 35-36, 39-48, 50-51, 54-58, 61-66, 68-72, 75-77, 79-82, 84-94, 97-98, 100-107, 109, 111-148, 151-194, 197-215, 217-235, 237-239, 241-242, 244-245, 247
web-app/src/routes/settings/hardware.tsx76, 83, 95-98, 100-104, 107-109, 111-114, 116-120, 131-137, 144, 146-148, 150, 152-154, 156-163, 166-168, 171-178, 337, 339-344, 346, 366-368, 388
web-app/src/routes/settings/providers/$providerName.tsx2-8, 15, 22-42, 45-47, 49-53, 55-86, 89-97, 99, 101, 104-106, 108-109, 112-113, 115, 117-122, 125-126, 128-131, 137-143, 145-150, 152-153, 155-160, 162-168, 170-172, 175-181, 184-187, 189, 191-195, 197-221, 223, 225-235, 237-239, 241-251, 253-290, 292-298, 301-302, 304-311, 313-323, 327-329, 332, 335-337, 339-350, 353-357, 359-362, 365-366, 369-374, 376-383, 385-388, 390, 393-402, 404-408, 410-420, 422-424, 426-427, 429-430, 432, 434-435, 438-455, 457-462, 464-467, 469-475, 477-478, 480-495, 497-500, 502-510, 512-522, 524-533, 535-536, 539-549, 551-554, 556-566, 568-580, 582-583, 585-590, 592-598, 600, 602, 604, 606, 608, 610, 612-619, 621-623, 625-631, 633

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed cec4fa7 in 1 minute and 24 seconds. Click for details.
  • Reviewed 98 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/system-monitor.tsx:197
  • Draft comment:
    The GPU card is now wrapped with a {!IS_MACOS} check. Please ensure that IS_MACOS is properly defined (or imported) so that this conditional works as intended.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that IS_MACOS is properly defined or imported, which falls under the rule of not asking the author to ensure behavior is intended or to double-check things. This makes the comment not compliant with the rules.
2. web-app/src/routes/system-monitor.tsx:210
  • Draft comment:
    The span for GPU activation condition uses a ternary that applies 'hidden' when inactive, yet it still renders the text 'Inactive'. Consider conditionally rendering the span only when the device is active to avoid redundant markup.
  • Reason this comment was not posted:
    Comment was on unchanged code.
3. web-app/src/routes/system-monitor.tsx:203
  • Draft comment:
    The GPU device mapping logic is duplicated inline. Consider extracting it into a reusable component to improve readability and maintainability, especially if similar UI elements are used elsewhere.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_9jK0TKjQdvtdRHo8

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 3ad6b75 in 50 seconds. Click for details.
  • Reviewed 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/settings/hardware.tsx:375
  • Draft comment:
    Swapped VRAM values: now displaying available VRAM (device.free) followed by total VRAM (device.mem) under the 'freeOf' label. Ensure that 'device.free' and 'device.mem' are used correctly to reflect free vs. total memory.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment is asking the author to ensure that 'device.free' and 'device.mem' are used correctly, which violates the rule against asking the author to ensure behavior is intended. However, it also provides a specific suggestion about the order of VRAM values, which could be useful.

Workflow ID: wflow_qZcxyEKE3oFo7dgA

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@urmauur urmauur moved this to QA in Jan Jul 26, 2025
@urmauur urmauur moved this from QA to Needs Review in Jan Jul 26, 2025
@urmauur urmauur requested a review from qnixsynapse July 26, 2025 05:29
@Minh141120
Copy link
Member

LGTM!

  • ✅ mem info
  • ✅ not call function getDevice gpu info on Mac
  • ✅ backend version update
image image

I also try to turn off auto update engine and select old version of backend, work as expected as it did not update to latest version, still pinning on old version

image

@Minh141120
Copy link
Member

[Windows]

  • free vs total gpu info also fixed as well
image

@urmauur urmauur merged commit b89d9d0 into release/v0.6.6 Jul 26, 2025
17 of 20 checks passed
@urmauur urmauur deleted the fix/last-rc branch July 26, 2025 11:36
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Jul 26, 2025
@urmauur urmauur moved this from QA to Done in Jan Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants