fix: models hub should show latest data only

[louis-jan]

Describe Your Changes

This PR is to enhance the hub model list to just display latest data from model catalog instead of merging previous models list with new update. It should also not to show HF model which is already exist in the list.

Fixes Issues

• Closes bug: Searching full HF repo ID shows duplicate models that already exist in list #5911
• Closes feat: Model hub should perform clean update instead of sync and merge with cached data #5905

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Ensure model hub displays only the latest data by updating useModelSources to avoid merging with existing data and preventing duplicate models from HuggingFace.

• Behavior:
  • useModelSources now fetches and displays only the latest model data, avoiding merging with existing data in useModelSources.ts.
  • Prevents adding duplicate models from HuggingFace in index.tsx by checking existing sources before adding.
• Tests:
  • Updated useModelSources.test.ts to reflect changes in merging logic, ensuring only new data is used.
  • Modified tests to check for non-duplication of models and correct handling of empty responses.

^{This description was created by for 5096a2a. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to cfcdedb in 2 minutes and 14 seconds. Click for details.

• Reviewed 64 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/hooks/useModelSources.ts:33

• Draft comment:
  Replace merging logic with assignment to latest data. Note that using newSources.length ? newSources : get().sources means that if the API returns an empty array, the old sources are retained. Ensure that this fallback behavior is intended.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. web-app/src/routes/hub/index.tsx:164

• Draft comment:
  Adding 'sources' to the dependency array ensures that the deduplication check uses the latest state. However, this might trigger extra API calls or re-renders if sources changes frequently. Verify if this behavior is intended or consider using a ref for stable access.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment suggests a potential issue with the current implementation, specifically that adding 'sources' to the dependency array might lead to unnecessary API calls or re-renders. It also provides a suggestion to use a ref for stable access. However, it asks the author to verify if the behavior is intended, which violates the rules. The suggestion to consider using a ref is valid, but the request to verify the behavior is not allowed.

3. web-app/src/routes/hub/index.tsx:142

• Draft comment:
  Both the useEffect and the search change handler set a timeout to fetch HF repo info. Consider adding a cleanup function in the useEffect hook (and ensuring any pending timeouts are cleared) to prevent overlapping timer callbacks on rapid dependency changes.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_yH7ai8YlNmHABnPD

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 5096a2a in 1 minute and 17 seconds. Click for details.

• Reviewed 100 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/hooks/__tests__/useModelSources.test.ts:98

• Draft comment:
  Updated test name and expectation to verify that new sources replace (not merge with) existing ones. This change aligns with the requirement to display only the latest catalog data.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining what was done and why. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. It violates the rule against making purely informative comments.

2. web-app/src/hooks/__tests__/useModelSources.test.ts:175

• Draft comment:
  Deduplication test updated to expect only new sources when duplicate model names occur. This ensures that existing HF models are not duplicated, meeting the issue requirements.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining what a test update does. It doesn't provide a suggestion, ask for confirmation on a specific change, or point out a potential issue. It violates the rule against making purely informative comments.

3. web-app/src/hooks/__tests__/useModelSources.test.ts:470

• Draft comment:
  Multiple fetch operations test now verifies that subsequent fetch calls replace rather than merge source data. This confirms that only the latest fetched data is maintained.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining what a test does. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. It violates the rule against making purely informative comments.

Workflow ID: wflow_pxVo1pfxSnHmEstF

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 37.38%

Your code coverage diff: -0.03% ▾

Uncovered files and lines

File

Lines

web-app/src/routes/hub/index.tsx

2-7, 15-24, 30, 36-40, 48, 50-55, 57-58, 60-83, 85-86, 89-90, 92-95, 98, 100-104, 107, 109-114, 116-128, 130-135, 137-140, 142-143, 145-154, 156-164, 167-174, 176-178, 181-182, 184-198, 200-208, 210-220, 223-227, 229-231, 233-236, 238-240, 242-246, 248-249, 251-260, 263-271, 273-274, 276-286, 288, 290-293, 295-309, 311-312, 314-325, 327-328, 330, 332-348, 350, 352-354, 356-361, 363-369, 371-375, 377-378, 380-385, 387-388, 390, 392-402, 404-405, 408-417, 419-420, 422-438, 440-444, 447-448, 451-452, 454-471, 474, 476-481, 483-484, 486-496, 498-512, 514, 516-549, 551-554, 556-581, 583-592, 594-610, 612-626, 629-635, 638-647, 649-654, 657-667, 669-673, 675-713, 715-719, 721-725, 727-761, 763-769, 771-775, 777-779, 781, 783-787, 789-795, 798-800, 802, 804-816, 818-822, 824-825, 827, 829-830, 832-836, 838-842, 844