fix: validate name assistant and improve area clickable

[urmauur]

Describe Your Changes

This pull request introduces validation for assistant names in the AddEditAssistant dialog, improves user feedback for invalid inputs, and adjusts the layout of the dropdown menu for better usability. Additionally, it updates locale files to support the new validation message in multiple languages.

Validation and user feedback improvements:

• web-app/src/containers/dialogs/AddEditAssistant.tsx: Added a nameError state to track validation errors for the assistant name, implemented validation logic in the handleSave function to ensure the name is not empty, and displayed an error message below the name input field when validation fails. [1] [2] [3] [4]

Localization updates:

• Locale files (web-app/src/locales/de-DE/assistants.json, web-app/src/locales/en/assistants.json, web-app/src/locales/id/assistants.json, web-app/src/locales/vn/assistants.json, web-app/src/locales/zh-CN/assistants.json, web-app/src/locales/zh-TW/assistants.json): Added translations for the new validation message "Name is required" in German, English, Indonesian, Vietnamese, Simplified Chinese, and Traditional Chinese. [1] [2] [3] [4] [5] [6]

Dropdown menu layout adjustment:

• web-app/src/containers/DropdownAssistant.tsx: Modified the layout of dropdown menu items by adding a w-full class to ensure consistent full-width styling.

Fixes Issues

• Closes bug: App Should Not Allow Creating an Empty Assistant #5916
• Closes bug: Assistant switch can only activate when click directly on the text #5652

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Adds validation for assistant names, updates localization for error messages, and improves dropdown menu layout.

• Validation and Feedback:
  • AddEditAssistant.tsx: Adds nameError state for assistant name validation, ensuring the name is not empty. Displays error message below input field.
• Localization:
  • Updates locale files for German, English, Indonesian, Vietnamese, Simplified Chinese, and Traditional Chinese to include "Name is required" message.
• UI Enhancements:
  • DropdownAssistant.tsx: Adds w-full class to dropdown menu items for consistent full-width styling.

^{This description was created by for 41d469e. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 41d469e in 2 minutes and 13 seconds. Click for details.

• Reviewed 176 lines of code in 8 files
• Skipped 0 files when reviewing.
• Skipped posting 11 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/DropdownAssistant.tsx:84

• Draft comment:
  Adding 'w-full' to the dropdown menu item ensures the entire area is clickable; this improves usability.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. web-app/src/containers/dialogs/AddEditAssistant.tsx:64

• Draft comment:
  Introducing the 'nameError' state is a clean approach to managing validation feedback for the assistant name.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. web-app/src/containers/dialogs/AddEditAssistant.tsx:197

• Draft comment:
  The validation logic in handleSave properly checks for an empty name and prevents saving when the field is blank.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. web-app/src/containers/dialogs/AddEditAssistant.tsx:285

• Draft comment:
  Clearing 'nameError' within the onChange handler for the name input gives immediate feedback as soon as the user types a non‑empty value.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

5. web-app/src/containers/dialogs/AddEditAssistant.tsx:295

• Draft comment:
  Displaying the error message below the name input provides clear user feedback when the input is invalid.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

6. web-app/src/locales/de-DE/assistants.json:13

• Draft comment:
  Added the 'nameRequired' translation in German, ensuring consistency for validation messages.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

7. web-app/src/locales/en/assistants.json:13

• Draft comment:
  The English locale now includes the 'nameRequired' key, which aligns with the validation update.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

8. web-app/src/locales/id/assistants.json:13

• Draft comment:
  The Indonesian translation now properly includes 'nameRequired', enhancing multilingual support.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

9. web-app/src/locales/vn/assistants.json:13

• Draft comment:
  Added 'nameRequired' for Vietnamese, ensuring consistent validation messaging across locales.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

10. web-app/src/locales/zh-CN/assistants.json:13

• Draft comment:
  The Simplified Chinese locale now has the 'nameRequired' key, which is important for proper validation feedback.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

11. web-app/src/locales/zh-TW/assistants.json:13

• Draft comment:
  The Traditional Chinese translations include 'nameRequired', maintaining consistency with other locales.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_jTLuGUS3CN8gtv5g

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 37.38%

Your code coverage diff: -0.03% ▾

Uncovered files and lines

File	Lines
web-app/src/containers/DropdownAssistant.tsx	1-2, 9-13, 15-28, 30-31, 33-47, 49-62, 64-75, 77-80, 82-88, 90-97, 100-117, 119-124, 126-127, 129-140, 142-152, 154, 156
web-app/src/containers/dialogs/AddEditAssistant.tsx	1-2, 9-11, 17, 19-20, 22, 28-32, 42-49, 51-64, 67-75, 77-79, 81-84, 87-92, 94-95, 98-103, 105-108, 110-112, 114-123, 125-135, 138-148, 150-154, 156-159, 162, 164-172, 174-177, 179-183, 185-195, 197-202, 204-209, 211-223, 225, 227-245, 247-252, 254, 256-266, 268-277, 279-293, 295-298, 301-311, 313-324, 326-336, 338-341, 343-345, 348-367, 369-377, 379-383, 385-390, 392-394, 396-400, 402-405, 407-409, 411-417, 419-430, 433-437, 440-444, 447-451, 454-457, 459-467, 469-480, 483-487, 490-499, 501-502, 504-506, 508-511, 513-516, 518-521, 523-528, 530-534, 536

[louis-jan]

LGTM