-
Notifications
You must be signed in to change notification settings - Fork 2.4k
ci: rename app github artifact on windows and linux build #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to e1a526c in 4 minutes and 13 seconds. Click for details.
- Reviewed
34lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/template-tauri-build-windows-x64.yml:198
- Draft comment:
The Windows upload artifact name now uses the channel (e.g. 'jan-${{ inputs.channel }}-windows-${{ inputs.new_version }}.exe'), which may conflict with the spec (stable builds expected as 'jan-windows-…' without 'stable'). Also, later steps (not in this diff) use a different naming pattern (including a '-setup' suffix). Please ensure a unified, conditional naming scheme that omits the channel for stable versions and is consistent across steps. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While the comment identifies a real inconsistency, it's more of a suggestion to verify and standardize naming patterns. It uses language like "Please ensure..." which our rules explicitly say to avoid. It's also speculative about potential conflicts rather than pointing out a definite issue. The build will still work despite the naming differences. The naming inconsistency could cause real problems with artifact handling and updates. Maybe this is more serious than I'm thinking. While naming consistency is good, the build system will still function. This is more of a "nice to have" standardization request than a critical issue requiring immediate attention. The comment should be deleted because it uses speculative language, asks for verification, and doesn't point out a definite problem that needs fixing.
Workflow ID: wflow_8JBYGPQjsDFz3WUL
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed eb31bf3 in 1 minute and 44 seconds. Click for details.
- Reviewed
39lines of code in3files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/template-tauri-build-linux-x64.yml:167
- Draft comment:
Avoid nested interpolation. Use the ternary operator instead, e.g.jan${{ inputs.channel == 'stable' ? '' : '-' + inputs.channel }}-linux-amd64-${{ inputs.new_version }}.deb. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. .github/workflows/template-tauri-build-linux-x64.yml:174
- Draft comment:
The AppImage artifact name isn’t updated with conditional logic. It should omit '-stable' for stable builds (using the same conditional as for .deb). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. .github/workflows/template-tauri-build-macos.yml:189
- Draft comment:
Avoid nested interpolation here as well. Use a ternary operator likejan${{ inputs.channel == 'stable' ? '' : '-' + inputs.channel }}-mac-universal-${{ inputs.new_version }}.dmg. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. .github/workflows/template-tauri-build-windows-x64.yml:200
- Draft comment:
Avoid nested interpolation; use the ternary operator for clarity, e.g.jan${{ inputs.channel == 'stable' ? '' : '-' + inputs.channel }}-windows-${{ inputs.new_version }}.exe. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_lxAuYgkgERtxQ1Fq
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 9c6bac3 in 1 minute and 35 seconds. Click for details.
- Reviewed
47lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/template-tauri-build-linux-x64.yml:167
- Draft comment:
Using the conditional expression with && and || together with format() for artifact naming works, but it may be less intuitive. Consider adding a brief inline comment to clarify the logic and ensure future maintainers understand that for a 'stable' channel the prefix is 'jan', otherwise 'jan-'. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. .github/workflows/template-tauri-build-macos.yml:189
- Draft comment:
The DMG artifact naming now uses the same conditional and format() function. Verify consistency with naming conventions since elsewhere the prefix might differ in capitalization. If intentional, consider a comment to note the naming design. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. .github/workflows/template-tauri-build-windows-x64.yml:201
- Draft comment:
The Windows artifact name update using format() and a conditional expression is consistent with Linux/macOS. Consider adding a comment to explain that for a 'stable' channel the prefix remains 'jan', and for others it prepends the channel (e.g., 'jan-nightly'). - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_Dl62NQwvXB4uXAjG
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This pull request updates the artifact naming conventions in the GitHub Actions workflows for Tauri builds. The changes ensure that the artifact names include the release channel (
inputs.channel) for better clarity and organization.Previously
Now we need to add input channel and extension for the filename, in case it's nightly build, it should be:
If input channel is stable version:
Workflow updates for artifact naming:
.github/workflows/template-tauri-build-linux-x64.yml: Updated the artifact names for.deband.AppImagefiles to include the release channel (inputs.channel)..github/workflows/template-tauri-build-windows-x64.yml: Updated the artifact name for.exefiles to include the release channel (inputs.channel).Important
Updates GitHub Actions workflows to include release channel in artifact names for Linux, Windows, and macOS Tauri builds.
.github/workflows/template-tauri-build-linux-x64.ymlto include release channel (inputs.channel) for.deband.AppImagefiles..github/workflows/template-tauri-build-windows-x64.ymlto include release channel for.exefiles..github/workflows/template-tauri-build-macos.ymlto include release channel for.dmgfiles.This description was created by
for 9c6bac3. You can customize this summary. It will automatically update as commits are pushed.