Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 21, 2025

Describe Your Changes

This is to add Claude-4 to default Anthropic models list.

CleanShot 2025-07-21 at 10 17 47@2x

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Add Claude-4 to default Anthropic models and reorder model merging in useModelProvider.ts.

  • Feature:
    • Add Claude-4 to default Anthropic models list.
  • Code Changes:
    • In useModelProvider.ts, reorder merging of models in setProviders() to prioritize provider models over existing models.
  • Dependencies:
    • Update token.js version from 0.7.15 to 0.7.16 in package.json.

This description was created by Ellipsis for 4d2fcac. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 79d9955 in 59 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/package.json:72
  • Draft comment:
    PR title suggests adding Claude-4 to the Anthropic models list, but the diff only shows a token.js dependency bump. Ensure that code changes updating the default model list are also included.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_4y4NiUIzFpD8BpI6

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Barecheck - Code coverage report

Total: 35.01%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
web-app/src/hooks/useModelProvider.ts31-36, 38-48, 50-52, 54-103, 105-116, 126-128, 130, 132-134, 137-140, 142-143, 145, 147-149, 151-164, 166-169, 171-176

@louis-jan louis-jan requested review from LazyYuuki and urmauur July 21, 2025 03:18
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 4d2fcac in 1 minute and 55 seconds. Click for details.
  • Reviewed 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/useModelProvider.ts:63
  • Draft comment:
    The ordering in mergedModels was reversed (provider models filtered come before existing stored models). Please add an inline comment explaining this change to ensure updated default models (e.g. Claude-4) are prioritized as intended.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The change does appear intentional and meaningful - it affects which models take precedence when there are conflicts. However, the comment is primarily asking for documentation rather than pointing out a bug or suggesting a concrete improvement. The reasoning about Claude-4 seems speculative since there's no clear evidence in the code about specific model priorities. The comment identifies a real change in behavior, and documentation could be helpful for future maintainers. Not having this documentation could lead to confusion about model precedence. While documentation can be valuable, our rules state we should not make purely informative comments. The code change appears intentional and the behavior is clear from the code itself. We should delete this comment as it's primarily requesting documentation rather than identifying a concrete issue that needs fixing.

Workflow ID: wflow_DpvWgK1IPKdqpkeH

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@LazyYuuki LazyYuuki linked an issue Jul 21, 2025 that may be closed by this pull request
@louis-jan louis-jan merged commit 05b9d4e into release/v0.6.6 Jul 21, 2025
21 of 24 checks passed
@louis-jan louis-jan deleted the feat/add-claude-4-to-model-list branch July 21, 2025 05:30
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 21, 2025
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

feat: Update Claude-4 in the default list of Anthropic model

5 participants