-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add Hugging Face Inference Endpoints as Model Provider #5642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 216399d in 1 minute and 52 seconds. Click for details.
- Reviewed
301lines of code in8files - Skipped
12files when reviewing. - Skipped posting
8draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/pages/docs/remote-models/_meta.json:30
- Draft comment:
New Hugging Face entry added; verify href matches the documentation URL. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. extensions/engine-management-extension/engines.mjs:11
- Draft comment:
Hugging Face provider imported and integrated into engines and models arrays correctly. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
3. extensions/engine-management-extension/models/huggingface.json:1
- Draft comment:
Empty model list is intentional; ensure users know to add models manually. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
4. extensions/engine-management-extension/resources/huggingface.json:11
- Draft comment:
The transform_req template is quite verbose; consider refactoring or externalizing the list of keys for maintainability. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. web-app/src/lib/utils.ts:34
- Draft comment:
Hugging Face provider logo and title added; ensure the SVG asset '/images/model-provider/hugging-face.svg' exists. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
6. web-app/src/mock/data.ts:287
- Draft comment:
Hugging Face provider settings added with correct placeholders; verify the base URL always ends with '/v1' per API requirements. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
7. docs/src/pages/docs/remote-models/huggingface.mdx:45
- Draft comment:
Typo: "cick on Create Endpoint" should be "click on Create Endpoint". - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While this is technically correct - there is a typo - the rules state we should not make purely informative comments. Typos in documentation, while worth fixing, are minor issues that don't affect functionality. The meaning is still clear despite the typo. The typo could potentially confuse non-native English speakers following the documentation. Documentation quality is important for user experience. While documentation quality matters, this particular typo is extremely minor and the meaning is obvious from context. This type of minor editorial feedback creates noise in the PR review process. Delete this comment as it's a minor documentation typo that doesn't affect functionality or comprehension significantly.
8. docs/src/pages/docs/remote-models/huggingface.mdx:64
- Draft comment:
Typo: "alongside you endpoint URL" should be "alongside your endpoint URL". - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While this is a real typo, typo fixes in documentation are very minor issues. The meaning is still clear despite the typo. Documentation typos don't affect functionality. However, since this is a new file being added, catching typos before they make it to production could improve quality. Documentation quality and correctness matters for user experience. Typos can make documentation look unprofessional. While documentation quality matters, this particular typo is extremely minor and obvious. The PR author will likely catch it in their own review. This comment, while technically correct, is too minor to be worth keeping in the PR review. It adds noise without significant value.
Workflow ID: wflow_CTRBK99NHyf2QnoC
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| <br/> | ||
|
|
||
| This will take you to the deployment set up page. For this example, we will leave the default settings | ||
| as they are under the GPU tab and cick on **Create Endpoint**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo alert: 'cick' should be 'click'.
| as they are under the GPU tab and cick on **Create Endpoint**. | |
| as they are under the GPU tab and click on **Create Endpoint**. |
|
Preview URL: https://e4c09b01.docs-9ba.pages.dev |
|
The objective has changed from Inference Endpoint to Inference Provider as HF team has expressed that on cost basis it is not suitable for casual user which is the main group of user for Jan right now. That being said, we can still cherry pick the example from the docs for and add it as instruction to create Custom Provider with Inference Endpoint instead. Refer to here for the current implementation in discussion: #5808 |
Add Hugging Face Inference Endpoints as Model Provider
This PR begins scaffolding proper integration with HF Inference Enpoints following issue #5281.
What's Added
Current Limitation
As noted by the HF team, the HF model router is not fully functioning yet due to an internal fix needed to proxy to the correct provider. This implementation provides a manual but functional approach that sets the foundation for a more streamlined experience once HF's auto-routing is ready.
Docs
Complete setup guide available at
/docs/remote-models/huggingfaceshowing users how to:Fixes: #5281
Important
Adds Hugging Face as a model provider with manual endpoint configuration and OpenAI-compatible API integration, including documentation and UI updates.
predefinedProvidersindata.ts.huggingface.json.huggingface.mdxfor integrating Hugging Face Inference Endpoints._meta.jsonto include Hugging Face documentation link.huggingface.jsontoengines.mjsfor engine and model management.resources/huggingface.json.utils.ts.This description was created by
for 216399d. You can customize this summary. It will automatically update as commits are pushed.