Skip to content

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Jun 30, 2025

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Update default base URL for Anthropic provider and bump token.js version.

  • Behavior:
    • Update default base_url for Anthropic provider in data.ts from https://api.anthropic.com/v1 to https://api.anthropic.com.
    • Update placeholder and value for Anthropic base-url setting in data.ts to https://api.anthropic.com.
  • Dependencies:
    • Update token.js version in package.json from 0.7.12 to 0.7.13.

This description was created by Ellipsis for 3c9091c. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to c2df2ca in 1 minute and 30 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_g7sR7oubF7w5OY3Y

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan
Copy link
Contributor

Should check from tokenjs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 980b20b in 47 seconds. Click for details.
  • Reviewed 24 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/mock/data.ts:64
  • Draft comment:
    Confirm that removing '/v1' from Anthropic's base_url is intentional. If so, consider adding an inline comment for future reference.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. web-app/src/mock/data.ts:89
  • Draft comment:
    Ensure the placeholder and value in the Anthropic settings now match the updated base_url without '/v1'.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_J6E8YANTT6IuXWYf

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 3c9091c in 50 seconds. Click for details.
  • Reviewed 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/package.json:69
  • Draft comment:
    Bump token.js dependency to v0.7.13. Verify that this update incorporates the Anthropic base URL fix and is backward compatible.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. web-app/package.json:97
  • Draft comment:
    Add a trailing newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_wzpqUKj5HTQ034I7

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@LazyYuuki LazyYuuki linked an issue Jul 3, 2025 that may be closed by this pull request
3 tasks
@LazyYuuki LazyYuuki added this to Jan Jul 3, 2025
@LazyYuuki LazyYuuki added this to the v0.6.5 milestone Jul 3, 2025
@LazyYuuki LazyYuuki moved this to In Progress in Jan Jul 3, 2025
@LazyYuuki LazyYuuki moved this from In Progress to Needs Review in Jan Jul 3, 2025
@samhvw8 samhvw8 merged commit 36c2024 into release/v0.6.5 Jul 4, 2025
18 checks passed
@samhvw8 samhvw8 deleted the fix/baseUrl-anthropic branch July 4, 2025 02:43
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Jul 4, 2025
@LazyYuuki LazyYuuki mentioned this pull request Jul 14, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: remote providers urls are fixed

4 participants