-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: update base URL for Anthropic provider #5600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to c2df2ca in 1 minute and 30 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_g7sR7oubF7w5OY3Y
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Should check from tokenjs |
c2df2ca to
980b20b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 980b20b in 47 seconds. Click for details.
- Reviewed
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/mock/data.ts:64
- Draft comment:
Confirm that removing '/v1' from Anthropic's base_url is intentional. If so, consider adding an inline comment for future reference. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/mock/data.ts:89
- Draft comment:
Ensure the placeholder and value in the Anthropic settings now match the updated base_url without '/v1'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_J6E8YANTT6IuXWYf
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 3c9091c in 50 seconds. Click for details.
- Reviewed
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/package.json:69
- Draft comment:
Bump token.js dependency to v0.7.13. Verify that this update incorporates the Anthropic base URL fix and is backward compatible. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/package.json:97
- Draft comment:
Add a trailing newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_wzpqUKj5HTQ034I7
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Describe Your Changes
Fixes Issues
Self Checklist
Important
Update default base URL for Anthropic provider and bump
token.jsversion.base_urlfor Anthropic provider indata.tsfromhttps://api.anthropic.com/v1tohttps://api.anthropic.com.placeholderandvaluefor Anthropicbase-urlsetting indata.tstohttps://api.anthropic.com.token.jsversion inpackage.jsonfrom0.7.12to0.7.13.This description was created by
for 3c9091c. You can customize this summary. It will automatically update as commits are pushed.