-
Notifications
You must be signed in to change notification settings - Fork 2.5k
✨enhancement: show app size on download dropdown #5360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 1ecce1e in 1 minute and 34 seconds. Click for details.
- Reviewed
172lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/components/Download/CardDownload.tsx:130
- Draft comment:
Consider using a instead of afor displaying the file size to ensure proper inline semantics. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. docs/src/components/Download/CardDownload.tsx:85
- Draft comment:
The asset lookup and file size formatting logic is duplicated across components. Consider extracting this into a shared helper function. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. docs/src/components/DropdownDownload/index.tsx:134
- Draft comment:
The use of 'await' on lastRelease.assets[0]?.name is unnecessary since it's not a promise. Please remove 'await'. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_HsrnCoh0ybqmchAV
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Preview URL: https://b9c07a3a.docs-9ba.pages.dev |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 4b75640 in 1 minute and 5 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/components/Home/Feature/index.tsx:47
- Draft comment:
The diff only updates the feature description for 'Chat with your files'—it doesn't include the changes for showing app download sizes (CardDownload/DropdownDownload and formatFileSize utility) as described in the PR. Please include those changes to fully resolve issue #4863. - Reason this comment was not posted:
Comment was on unchanged code.
2. docs/src/components/Home/Feature/index.tsx:46
- Draft comment:
Typo: 'experimantal' appears to be misspelled. It should likely be 'experimental'. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_qa612dY9pfEy893z
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
david-menloai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* ✨enhancement: show app size on download dropdown * Update docs/src/utils/format.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * chor: update copy --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Describe Your Changes
This pull request introduces functionality to display file sizes for downloadable assets in the
CardDownloadandDropdownDownloadcomponents, along with a new utility function to format file sizes. The changes enhance the user experience by providing additional information about the download files.Enhancements to
CardDownloadandDropdownDownloadcomponents:SystemType: Updated theSystemTypetype to include an optionalsizeproperty to store the formatted file size.formatFileSizeutility function.CardDownloadandDropdownDownloadcomponents, ensuring the size is shown alongside the system name.New utility function:
formatFileSizefunction: Added a utility function indocs/src/utils/format.tsto convert file sizes from bytes to a human-readable format (e.g., KB, MB, GB).Fixes Issues
Self Checklist
Important
Enhances
CardDownloadandDropdownDownloadcomponents to display file sizes using a newformatFileSizeutility function.CardDownload.tsxandDropdownDownload/index.tsxnow display file sizes next to download options.formatFileSize.formatFileSizeinformat.tsto convert bytes to human-readable format.SystemTypeto include optionalsizeproperty.Feature/index.tsx.This description was created by
for 4b75640. You can customize this summary. It will automatically update as commits are pushed.