Skip to content

fix: #396 - allow user to cancel a model download #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: #396 - allow user to cancel a model download #530

merged 2 commits into from
Nov 2, 2023

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 2, 2023 •
edited
Loading

Problem

Solution

  • Downloading button will be Cancel now, app manages requests and perform pause/cancel/abort accordingly (via CTA)
Screenshot 2023-11-02 at 15 37 38 Screenshot 2023-11-02 at 15 55 27

Action items:

  • Pause & Resume CTA are not available yet, please help on this @urmauur
  • Cloud native cancel action is not defined yet

@louis-jan louis-jan requested review from namchuai and urmauur November 2, 2023 08:47
@louis-jan louis-jan changed the title fix: #396 - allow user to cancel model download fix: #396 - allow user to cancel a model download Nov 2, 2023
louis-jan
louis-jan commented Nov 2, 2023
View reviewed changes
louis-jan
louis-jan commented Nov 2, 2023
View reviewed changes
@louis-jan louis-jan merged commit d29d076 into main Nov 2, 2023
@louis-jan louis-jan deleted the fix/396-allow-user-to-cancel-model-download branch November 2, 2023 12:58
@louis-jan louis-jan mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urmauur urmauur urmauur approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Menlo
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@louis-jan @urmauur