Skip to content

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Nov 1, 2023

Following: https://hackmd.io/@jan-ai/platform-sdk#Example-Making-a-character-with-a-knowledge-base-pdf-docs

  • Separating conversational plugin from data plugin
  • Move to file-based approach database

@namchuai namchuai force-pushed the create-conversational-plugin branch from 617e216 to a516ac1 Compare November 1, 2023 22:35
@namchuai namchuai requested review from louis-jan and urmauur November 1, 2023 22:36
@namchuai namchuai force-pushed the create-conversational-plugin branch from a516ac1 to 2eeb0ae Compare November 1, 2023 22:44
@namchuai namchuai marked this pull request as ready for review November 1, 2023 22:44
@louis-jan
Copy link
Contributor

@namchuai will it break CloudNative? Have you tried this under CloudNative mode?

@louis-jan louis-jan marked this pull request as draft November 3, 2023 12:32
@louis-jan
Copy link
Contributor

louis-jan commented Nov 3, 2023

@namchuai please don't merge it yet. Let's catch up later, there are a few upcoming changes.

@louis-jan louis-jan changed the title add conversational plugin [WIP] add conversational plugin Nov 3, 2023
@louis-jan louis-jan changed the title [WIP] add conversational plugin add conversational plugin Nov 3, 2023
@louis-jan louis-jan mentioned this pull request Nov 3, 2023
8 tasks
@namchuai namchuai force-pushed the create-conversational-plugin branch from 2eeb0ae to 5267432 Compare November 4, 2023 19:15
@namchuai namchuai force-pushed the create-conversational-plugin branch from 5267432 to 2043bea Compare November 5, 2023 07:31
@louis-jan louis-jan force-pushed the create-conversational-plugin branch from 2043bea to 47deff8 Compare November 6, 2023 04:24
@louis-jan louis-jan changed the base branch from main to feat/revamp-plugin-arch November 6, 2023 04:25
@louis-jan louis-jan force-pushed the feat/revamp-plugin-arch branch from d26a7dc to 189bd69 Compare November 6, 2023 04:26
@louis-jan louis-jan force-pushed the create-conversational-plugin branch from 47deff8 to 9dde00d Compare November 6, 2023 04:26
@louis-jan louis-jan marked this pull request as ready for review November 6, 2023 04:26
@louis-jan louis-jan merged commit c5826e2 into feat/revamp-plugin-arch Nov 6, 2023
@louis-jan louis-jan deleted the create-conversational-plugin branch November 6, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants