Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Oct 31, 2023

Problem

// Before
import * from "../../../../../electron/core/plugin-manager/execution/extension-manager"
// After
import * from "@plugin"

Solution

  • Ported plugin core modules to TS
  • Main plugin module placed in electron/plugin
  • Renderer plugin module placed in web/plugin

fixes #402

action items:

  • Plugin as exported class
Screenshot 2023-10-31 at 23 43 12

@louis-jan louis-jan requested review from namchuai and urmauur October 31, 2023 10:23
@louis-jan louis-jan marked this pull request as draft October 31, 2023 10:23
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@louis-jan louis-jan marked this pull request as ready for review November 1, 2023 02:48
@louis-jan louis-jan merged commit 37c3636 into main Nov 1, 2023
@louis-jan louis-jan deleted the feat/refactor-plugin-manager branch November 1, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

chore: plugin extension execution module should be a part of web / core rather than electron

4 participants