feat: Standardize inline error messages #4530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 67.94%Your code coverage diff: -0.05% ▾ Uncovered files and lines
|
louis-jan
approved these changes
Jan 28, 2025
louis-jan
had a problem deploying
to
production
GitHub Actions
Failure
louis-jan
had a problem deploying
to
production
GitHub Actions
Failure
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces several changes to the
ErrorMessagecomponent and its associated tests in order to enhance functionality and improve the user interface. The most important changes include the addition of new icons, a copy-to-clipboard feature, and updates to the test cases to reflect these changes.Enhancements to the
ErrorMessagecomponent:web/containers/ErrorMessage/index.tsx: Added new imports foruseRef,useState, and icons fromlucide-react. Introduced a copy-to-clipboard feature usinguseRefanduseStatehooks, and updated the error message display to include new styling and icons for troubleshooting and copying error messages. [1] [2] [3] [4] [5] [6]Updates to test cases:
web/containers/ErrorMessage/index.test.tsx: Updated test cases to reflect changes in the error message text and interactions. Specifically, changed references from 'troubleshooting assistance' to 'Troubleshooting' to match the updated UI. [1] [2]Fixes Issues
Tested long content with scroll behavior
Self Checklist