fix: mismatch NGL number between UI and model settings #4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Jan 15, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request addressed an issue where Jan application displayed an incorrect maximum number of NGL settings. It always displayed 100 instead of using the value specified in the model configuration.
Fixes Issues
Changes
This pull request includes a change to the
web/utils/componentSettings.tsfile to add a new case for handling 'ngl' settings in thegetConfigurationsDatafunction.The most important change is:
web/utils/componentSettings.ts: Added a new case 'ngl' to setcomponentSetting.controllerProps.maxbased onselectedModel?.settings.nglor a default value of 100.