fix: hide placeholder python engine and unsupported openai o1 system … #4455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Jan 15, 2025
Barecheck - Code coverage reportTotal: 69.26%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
louis-jan
deleted the
fix/hide-placeholder-engine-fix-o1-model-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…role
Describe Your Changes
This pull request resolved the issue where the Python engine was displayed in the app settings but was not functional. It also addressed the problem where users attempted to set assistant instructions for unsupported models, such as the OpenAI O1 family.
Fixes Issues
o1-mini&o1-preview#4392Changes
This pull request includes several changes aimed at improving the handling of engine data in the settings screen and refining the request transformation template for the OpenAI API.
Improvements to request transformation template:
extensions/engine-management-extension/resources/openai.json: Updated the template to handle different models and conditions more effectively, including specific handling for the "o1", "o1-preview", and "o1-mini" models.Enhancements to engine data handling in settings screen:
web/screens/Settings/Engines/index.tsx: Modified theEnginescomponent to ensure that engines with no length are not processed, improving the filtering logic for local and remote engines. [1] [2]web/screens/Settings/SettingLeftPanel/index.tsx: Updated theSettingLeftPanelcomponent to filter out engines with no length when determining which engines to display, enhancing the user interface by preventing empty engine entries. [1] [2]