Skip to content

Conversation

@louis-jan
Copy link
Contributor

Describe Your Changes

  • This PR fixes an issue where the app resets the default max_tokens to 8192, even if model settings specify a smaller number.

CleanShot 2025-01-15 at 10 38 27@2x

Fixes Issues

Self Checklist

This pull request includes a small but important change to the ModelDropdown component in the web/containers/ModelDropdown/index.tsx file. The change involves updating the property name used to determine the maximum number of tokens allowed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/containers/ModelDropdown/index.tsx126-127, 137, 150, 152, 154-155, 157-158, 160-163, 165, 187-188, 208-209, 216-219, 221, 223, 242, 247, 257, 264, 267-268, 289, 313, 336, 357, 366, 372, 385, 389, 391-396, 399, 402, 459-460, 462, 488, 496, 498, 523, 528-529, 531, 535-537, 539-540, 542, 552-555, 586, 594, 596

@github-actions
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-jan louis-jan merged commit 58bb1b4 into dev Jan 15, 2025
19 checks passed
@louis-jan louis-jan deleted the fix/incorrect_default_max_tokens branch January 15, 2025 05:37
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 15, 2025
@hantran-co hantran-co modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: [0.5.12] max_tokens automatically revert back to 8192 when users create a new thread

4 participants