fix: should not disable Vulkan support option #4382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Jan 2, 2025
Contributor
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Users should not be restricted from enabling Vulkan mode solely based on GPU detection.
Context:
Fixes Issues
Self Checklist
This pull request includes a change to the
Advancedcomponent in theSettingsscreen. The change simplifies the condition for displaying the Vulkan settings for AMD GPU/APU and Intel Arc GPU by removing the dependency ongpuList.length.web/screens/Settings/Advanced/index.tsx: Simplified the condition for displaying Vulkan settings by removing the check forgpuList.length > 0.