Skip to content

Conversation

@louis-jan
Copy link
Contributor

Describe Your Changes

This PR addresses an issue where the app frontend displays an active running model even after the user forcefully terminates the cortex-server.cpp process through the activity monitor.

Before killing the process
CleanShot 2024-11-26 at 19 02 05

After killing the process
CleanShot 2024-11-26 at 19 02 20

Fixes Issues

  1. Whitespace Adjustment:

    • A line containing only whitespace was modified. An unnecessary trailing whitespace was removed on line 71.
  2. Event Emission on WebSocket Closure:

    • A new line was added after the console.log('WebSocket closed:', event) within the this.socket.onclose function. The new line emits an event ModelEvent.OnModelStopped with an empty object ({}) as the payload. This likely triggers logic elsewhere in the application when a WebSocket connection is closed.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.18%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-jan
Copy link
Contributor Author

@louis-jan louis-jan merged commit 15588fa into dev Nov 26, 2024
21 checks passed
@louis-jan louis-jan deleted the fix/4012-active-model-stopped-on-process-exit branch November 26, 2024 14:30
@github-actions github-actions bot added this to the v0.5.10 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants