Skip to content

Commit d347058

Browse files
authored
fix: HuggingFace provider should be non-deletable (#5856)
* fix: HuggingFace provider should be non-deletable * refactor: rename const folder * test: correct test case
1 parent 8e9cd25 commit d347058

File tree

6 files changed

+122
-97
lines changed

6 files changed

+122
-97
lines changed
File renamed without changes.

web-app/src/containers/dialogs/DeleteProvider.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import {
1212

1313
import { toast } from 'sonner'
1414
import { CardItem } from '../Card'
15-
import { models } from 'token.js'
1615
import { EngineManager } from '@janhq/core'
1716
import { useModelProvider } from '@/hooks/useModelProvider'
1817
import { useRouter } from '@tanstack/react-router'
1918
import { route } from '@/constants/routes'
2019
import { useTranslation } from '@/i18n/react-i18next-compat'
20+
import { predefinedProviders } from '@/consts/providers'
2121

2222
type Props = {
2323
provider?: ProviderObject
@@ -28,7 +28,7 @@ const DeleteProvider = ({ provider }: Props) => {
2828
const router = useRouter()
2929
if (
3030
!provider ||
31-
Object.keys(models).includes(provider.provider) ||
31+
predefinedProviders.some((e) => e.provider === provider.provider) ||
3232
EngineManager.instance().get(provider.provider)
3333
)
3434
return null

web-app/src/routes/settings/providers/$providerName.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import { IconFolderPlus, IconLoader, IconRefresh } from '@tabler/icons-react'
3737
import { getProviders } from '@/services/providers'
3838
import { toast } from 'sonner'
3939
import { useEffect, useState } from 'react'
40-
import { predefinedProviders } from '@/mock/data'
40+
import { predefinedProviders } from '@/consts/providers'
4141
import { useModelLoad } from '@/hooks/useModelLoad'
4242

4343
// as route.threadsDetail

web-app/src/routes/settings/providers/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
import { Input } from '@/components/ui/input'
2323
import { Switch } from '@/components/ui/switch'
2424
import { useCallback, useState } from 'react'
25-
import { openAIProviderSettings } from '@/mock/data'
25+
import { openAIProviderSettings } from '@/consts/providers'
2626
import cloneDeep from 'lodash/cloneDeep'
2727
import { toast } from 'sonner'
2828

@@ -38,7 +38,9 @@ function ModelProviders() {
3838
const [name, setName] = useState('')
3939

4040
const createProvider = useCallback(() => {
41-
if (providers.some((e) => e.provider.toLowerCase() === name.toLowerCase())) {
41+
if (
42+
providers.some((e) => e.provider.toLowerCase() === name.toLowerCase())
43+
) {
4244
toast.error(t('providerAlreadyExists', { name }))
4345
return
4446
}

0 commit comments

Comments
 (0)