fix: HuggingFace provider should be non-deletable

[louis-jan]

Describe Your Changes

This PR addresses feedback from #5808 regarding how we determine first-class provider status. Instead of using token.js registration as the check, we now implement a proper predefined list to identify first-class providers that should be non-deletable.

#5281

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Refactor to use a predefined list for non-deletable providers, updating logic in DeleteProvider.tsx, $providerName.tsx, and providers.ts.

• Behavior:
  • DeleteProvider.tsx: Uses predefinedProviders to check non-deletable status instead of models from token.js.
  • $providerName.tsx: Updates import path for predefinedProviders.
  • providers.ts: Uses predefinedProviders for built-in providers.
• Tests:
  • providers.test.ts: Updates mock for predefinedProviders to reflect new import path and logic.
• Misc:
  • Renames web-app/src/mock/data.ts to web-app/src/consts/providers.ts.
  • Minor formatting changes in providers.test.ts and providers.ts.

^{This description was created by for 6acb12e. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 0d174db in 1 minute and 4 seconds. Click for details.

• Reviewed 27 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/dialogs/DeleteProvider.tsx:20

• Draft comment:
  Importing predefinedProviders from '@/mock/data' replaces token.js models. Consider moving this config to a dedicated production config file if it's not meant only for mock/testing.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

2. web-app/src/containers/dialogs/DeleteProvider.tsx:31

• Draft comment:
  The check using predefinedProviders.some() improves first-class provider detection. Consider extracting this logic into a helper function to enhance clarity and maintainability, and ensure the expected provider property exists in each predefined provider object.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_fSORwz0jQgnKQ0dI

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed bdc83b0 in 1 minute and 27 seconds. Click for details.

• Reviewed 61 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/dialogs/DeleteProvider.tsx:31

• Draft comment:
  Consider using a case‐insensitive comparison (e.g. using toLowerCase()) when checking if the provider is in predefinedProviders to be consistent with the provider creation check.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. web-app/src/routes/settings/providers/$providerName.tsx:369

• Draft comment:
  Same as above – for consistency, consider using a case‐insensitive check when comparing provider names in predefinedProviders.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. web-app/src/routes/settings/providers/index.tsx:25

• Draft comment:
  The import update from '@/mock/data' to '@/consts/providers' looks appropriate; ensure that the new constants match expected structure.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the new constants match the expected structure, which is a form of asking them to double-check their work. This violates the rule against asking the author to ensure behavior is intended or to double-check things.

Workflow ID: wflow_ntbCYFaCDM5ngjiZ

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed 6acb12e in 1 minute and 59 seconds. Click for details.

• Reviewed 425 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/services/__tests__/providers.test.ts:305

• Draft comment:
  Mixing snake_case and camelCase keys (e.g. controller_type vs. controllerType) can be confusing. Consider standardizing the naming convention.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. web-app/src/services/__tests__/providers.test.ts:120

• Draft comment:
  PR title mentions HuggingFace provider non-deletability but no test covers it. Add a test to verify that the HuggingFace (or similar predefined) provider cannot be deleted.
• Reason this comment was not posted:
  Comment was on unchanged code.

3. web-app/src/services/__tests__/providers.test.ts:18

• Draft comment:
  Consistent use of trailing commas throughout mocks improves readability and diff clarity. Good job!
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_ewMKzgS4hkd6JqWp

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 36.94%

Your code coverage diff: 1.79% ▴

Uncovered files and lines

File	Lines
web-app/src/containers/dialogs/DeleteProvider.tsx	1-2, 13-20, 25-32, 34, 36-52, 54-75, 77-87, 89-94, 96, 98-99
web-app/src/routes/settings/providers/$providerName.tsx	1-8, 15, 22-41, 44-46, 48-52, 54-86, 88, 90, 93-95, 97-98, 100-101, 103-108, 110-116, 118-120, 123-129, 132-135, 137, 139-143, 145-169, 171, 173-183, 185-187, 189-199, 201-238, 240-246, 249-250, 252-263, 267-268, 271, 274-276, 278-289, 292-301, 303-310, 312-316, 319-327, 329-333, 335-345, 347-349, 351-352, 354-355, 357, 359-360, 363-380, 382-387, 389-392, 394-400, 402-403, 405-420, 422-425, 427-435, 437-447, 449-458, 460-461, 464-474, 476-479, 481-491, 493-505, 507-508, 510-515, 517-523, 525, 527, 529, 531, 533, 535, 537-544, 546-548, 550-556, 558
web-app/src/routes/settings/providers/index.tsx	41-63, 107-108, 133-146, 148-162, 164-168, 170-179, 181
web-app/src/services/providers.ts	32, 57, 74, 80, 96-100, 190-191