This repository was archived by the owner on Sep 14, 2025. It is now read-only.
Fully implement List Objects V2 with pagination response elements#424
Merged
Conversation
This doesn't impact any existing behavior, but does fix a minor regression in accuracy caused by switching away from xml2js.
"starts-after" for GET Bucket v2, and all pagination-related response data is unimplemented. Also, the current behavior for "marker"/"starts-after" erroneously requires a key starting with the marker to exist to work properly. This also removes a few redundant tests relating to listObjects.
kherock
changed the title
Collaborator
|
@kherock Heroic effort man keep it up 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #110. This implements "starts-after" for GET Bucket v2 as well all pagination-related response data for both the v1 and v2 APIs. This also fixes the behavior for "marker"/"starts-after" (they erroneously require a key starting with the marker to exist in order to work properly).
I also ended up doing some significant refactoring to the tests around listObjects since they weren't very strict and also ran very slowly (it actually isn't necessary to generate 1000+ objects to make adequate test cases most of the time).