Allow specification of signing algo#423
Merged
Merged
Conversation
Contributor
Author
|
FYI tests in CI are failing due to this dotnet/aspnetcore#65391 :) |
james-gould
reviewed
Feb 19, 2026
Owner
james-gould
left a comment
james-gould
left a comment
There was a problem hiding this comment.
Hello! Thank you very much for this, really appreciate the contribution. Couple of small ammendments but overall good to go. If you could add some appropriate tests (ideally 1 per algo) that would be great too.
Noticed the issue for dotnet dev-certs as well, the workflows releasing the API change also use dotnet dev-certs which will block releasing so I'll await a fix for the bug before merging 😃
james-gould
approved these changes
Feb 20, 2026
Owner
|
Thank you mate, appreciate your time on this! Will try the workaround listed on the issue for |
Contributor
Author
|
No problem :) |
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
/signand/verifyendpoint properly respect the signing algorithm passed in from the request.Issue ticket number and link
Checklist before requesting a review