Skip to content

missing $ for string interpolation#418

Merged
james-gould merged 1 commit intojames-gould:masterfrom
tebeco:missing-string-interpolation
Jan 30, 2026
Merged

missing $ for string interpolation#418
james-gould merged 1 commit intojames-gould:masterfrom
tebeco:missing-string-interpolation

Conversation

@tebeco
Copy link
Copy Markdown
Contributor

@tebeco tebeco commented Jan 30, 2026

Describe your changes

Error in CI/CD shows:

  AzureKeyVaultEmulator.TestContainers.Exceptions.KeyVaultEmulatorException : CRT is required for a Linux host machine but was missing at path: {pfxPath}.

Issue ticket number and link

No ticket was opened for this one

- throw new KeyVaultEmulatorException( "CRT .......... {pfxPath}.");
+ throw new KeyVaultEmulatorException($"CRT .......... {pfxPath}.");

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have ran the test suite locally to ensure no breaking changes have been added.
  • I have not removed or changed Azure Key Vault endpoints which break SDK functionality.
  • NOT APPLICABLE: I have added new tests, if applicable.

Copilot AI review requested due to automatic review settings January 30, 2026 07:18
@tebeco tebeco requested a review from james-gould as a code owner January 30, 2026 07:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a string interpolation bug in an error message where the missing $ prefix caused the literal text {pfxPath} to be displayed instead of the actual path value.

Changes:

  • Added the missing $ character for string interpolation in a KeyVaultEmulatorException error message

@james-gould james-gould merged commit b55a1b5 into james-gould:master Jan 30, 2026
10 of 11 checks passed
@tebeco tebeco deleted the missing-string-interpolation branch January 30, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants